[Lex][Clang] Add checking to HeaderMapImpl::getString to make it more robust (#131677)

Static analysis identified the Len - 1 expression in
HeaderMapImpl::getString as problematic if Len is zero. After filing
this issue:

#130185

Indeed we should be checking MaxLen and verify it is not zero as well.

Fixes: #130185

Author: shafik

clang/lib/Lex/HeaderMap.cpp

@@ -155,6 +155,10 @@ std::optional<StringRef> HeaderMapImpl::getString(unsigned StrTabIdx) const {
 
   const char *Data = FileBuffer->getBufferStart() + StrTabIdx;
   unsigned MaxLen = FileBuffer->getBufferSize() - StrTabIdx;
+
+  if (MaxLen == 0)
+    return std::nullopt;
+
   unsigned Len = strnlen(Data, MaxLen);
 
   // Check whether the buffer is null-terminated.