[lld] Fix warning in SymbolTable.cpp (#112323)

karka228 · web-flow · commit cfc10bea9d18 · 2024-10-16T06:34:54.000+02:00
Fix gcc warning:

lld/ELF/SymbolTable.cpp:340:33: warning: enumeral and non-enumeral type
in conditional expression [-Wextra]
diff --git a/lld/ELF/SymbolTable.cpp b/lld/ELF/SymbolTable.cpp
@@ -337,7 +337,7 @@ void SymbolTable::scanVersionScript() {
         globalAsteriskFound = !isLocal;
       }
     }
-    assignWildcard(pat, isLocal ? VER_NDX_LOCAL : ver->id, ver->name);
+    assignWildcard(pat, isLocal ? (uint16_t)VER_NDX_LOCAL : ver->id, ver->name);
   };
   for (VersionDefinition &v : llvm::reverse(ctx.arg.versionDefinitions)) {
     for (SymbolVersion &pat : v.nonLocalPatterns)

Original file line number	Diff line number	Diff line change
`@@ -337,7 +337,7 @@ void SymbolTable::scanVersionScript() {`
`337`	`337`	`globalAsteriskFound = !isLocal;`
`338`	`338`	`}`
`339`	`339`	`}`
`340`		`- assignWildcard(pat, isLocal ? VER_NDX_LOCAL : ver->id, ver->name);`
	`340`	`+ assignWildcard(pat, isLocal ? (uint16_t)VER_NDX_LOCAL : ver->id, ver->name);`
`341`	`341`	`};`
`342`	`342`	`for (VersionDefinition &v : llvm::reverse(ctx.arg.versionDefinitions)) {`
`343`	`343`	`for (SymbolVersion &pat : v.nonLocalPatterns)`