Skip to content

Commit d016712

Browse files
authored
[bzl] Remove obsolete output_to_genfiles = True (#83944)
The [bazel docs](https://bazel.build/rules/lib/globals/bzl#rule) discourage setting this. The comments about being necessary for headers or genrules seem to be obsolete, at least for the LLVM tree itself. The effect of this is that generated files will go to `bazel-bin` instead of `bazel-genfiles`. One external use was fixed here: jax-ml/jax@32bb3b0.
1 parent cec2073 commit d016712

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

utils/bazel/llvm-project-overlay/llvm/enum_targets_gen.bzl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,5 @@ enum_targets_gen = rule(
6464
" `@LLVM_ENUM_{macro_name}S@`",
6565
),
6666
},
67-
# output_to_genfiles is required for header files.
68-
output_to_genfiles = True,
6967
implementation = enum_targets_gen_impl,
7068
)

utils/bazel/llvm-project-overlay/mlir/tblgen.bzl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,6 @@ def _gentbl_rule_impl(ctx):
181181
gentbl_rule = rule(
182182
_gentbl_rule_impl,
183183
doc = "Generates tabular code from a table definition file.",
184-
# Match genrule behavior
185-
output_to_genfiles = True,
186184
attrs = {
187185
"tblgen": attr.label(
188186
doc = "The TableGen executable with which to generate `out`.",

0 commit comments

Comments
 (0)