[ADT] Avoid repeated hash lookups (NFC) (#131418)

kazutakahirata · web-flow · commit d0177670a0e5 · 2025-03-15T21:01:19.000-07:00
diff --git a/llvm/include/llvm/ADT/SCCIterator.h b/llvm/include/llvm/ADT/SCCIterator.h
@@ -366,9 +366,9 @@ scc_member_iterator<GraphT, GT>::scc_member_iterator(
     Queue.pop();
     Nodes.push_back(Node);
     for (auto &Edge : Node->Edges) {
-      NodeInfoMap[Edge.Target].IncomingMSTEdges.erase(&Edge);
-      if (MSTEdges.count(&Edge) &&
-          NodeInfoMap[Edge.Target].IncomingMSTEdges.empty()) {
+      NodeInfo &Info = NodeInfoMap[Edge.Target];
+      Info.IncomingMSTEdges.erase(&Edge);
+      if (MSTEdges.count(&Edge) && Info.IncomingMSTEdges.empty()) {
         Queue.push(Edge.Target);
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -366,9 +366,9 @@ scc_member_iterator<GraphT, GT>::scc_member_iterator(`
`366`	`366`	`Queue.pop();`
`367`	`367`	`Nodes.push_back(Node);`
`368`	`368`	`for (auto &Edge : Node->Edges) {`
`369`		`- NodeInfoMap[Edge.Target].IncomingMSTEdges.erase(&Edge);`
`370`		`- if (MSTEdges.count(&Edge) &&`
`371`		`- NodeInfoMap[Edge.Target].IncomingMSTEdges.empty()) {`
	`369`	`+ NodeInfo &Info = NodeInfoMap[Edge.Target];`
	`370`	`+ Info.IncomingMSTEdges.erase(&Edge);`
	`371`	`+ if (MSTEdges.count(&Edge) && Info.IncomingMSTEdges.empty()) {`
`372`	`372`	`Queue.push(Edge.Target);`
`373`	`373`	`}`
`374`	`374`	`}`