Skip to content

Commit d0b644e

Browse files
committed
Address Comments of @arsenm.
1 parent 8367c38 commit d0b644e

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

clang/lib/Driver/ToolChains/AMDGPU.cpp

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1016,17 +1016,16 @@ RocmInstallationDetector::getCommonBitcodeLibs(
10161016

10171017
// GPU Sanitizer currently only supports ASan and is enabled through host
10181018
// ASan.
1019-
auto GPUSanEnabled = [GPUSan]() {
1020-
return std::get<bool>(GPUSan) &&
1021-
std::get<const SanitizerArgs>(GPUSan).needsAsanRt();
1022-
};
1019+
bool GPUSanEnabled = std::get<bool>(GPUSan) &&
1020+
std::get<const SanitizerArgs>(GPUSan).needsAsanRt();
1021+
10231022
auto AddBCLib = [&](ToolChain::BitCodeLibraryInfo BCLib,
10241023
bool Internalize = true) {
10251024
BCLib.ShouldInternalize = Internalize;
10261025
BCLibs.emplace_back(BCLib);
10271026
};
10281027
auto AddSanBCLibs = [&]() {
1029-
if (GPUSanEnabled()) {
1028+
if (GPUSanEnabled) {
10301029
AddBCLib(getAsanRTLPath(), false);
10311030
}
10321031
};
@@ -1035,7 +1034,7 @@ RocmInstallationDetector::getCommonBitcodeLibs(
10351034
AddBCLib(getOCMLPath());
10361035
if (!isOpenMP)
10371036
AddBCLib(getOCKLPath());
1038-
else if (GPUSanEnabled() && isOpenMP)
1037+
else if (GPUSanEnabled && isOpenMP)
10391038
AddBCLib(getOCKLPath(), false);
10401039
AddBCLib(getDenormalsAreZeroPath(DAZ));
10411040
AddBCLib(getUnsafeMathPath(UnsafeMathOpt || FastRelaxedMath));

0 commit comments

Comments
 (0)