Skip to content

Commit d0f3943

Browse files
authored
[RISCV] Remove -riscv-disable-insert-vsetvl-phi-opt flag (#97991)
This flag was added in https://reviews.llvm.org/D103277 out of precaution, but it's been enabled by default for 3 years now and I haven't seen any miscompiles upstream stemming from needVSETVLIPHI. This would remove it just to simplify the number of configurations.
1 parent 4010f89 commit d0f3943

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,6 @@ using namespace llvm;
4141
STATISTIC(NumInsertedVSETVL, "Number of VSETVL inst inserted");
4242
STATISTIC(NumCoalescedVSETVL, "Number of VSETVL inst coalesced");
4343

44-
static cl::opt<bool> DisableInsertVSETVLPHIOpt(
45-
"riscv-disable-insert-vsetvl-phi-opt", cl::init(false), cl::Hidden,
46-
cl::desc("Disable looking through phis when inserting vsetvlis."));
47-
4844
namespace {
4945

5046
/// Given a virtual register \p Reg, return the corresponding VNInfo for it.
@@ -1364,9 +1360,6 @@ void RISCVInsertVSETVLI::computeIncomingVLVTYPE(const MachineBasicBlock &MBB) {
13641360
// outputs from the last VSETVLI in their respective basic blocks.
13651361
bool RISCVInsertVSETVLI::needVSETVLIPHI(const VSETVLIInfo &Require,
13661362
const MachineBasicBlock &MBB) const {
1367-
if (DisableInsertVSETVLPHIOpt)
1368-
return true;
1369-
13701363
if (!Require.hasAVLReg())
13711364
return true;
13721365

0 commit comments

Comments
 (0)