Skip to content

Commit d115b0b

Browse files
committed
Tweak doc wording
1 parent 8ff6b68 commit d115b0b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

clang/include/clang/Basic/DiagnosticGroups.td

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -807,8 +807,8 @@ Warns when objects which are supposed to be globally unique might get duplicated
807807
when built into a shared library.
808808

809809
This can occur to objects which are hidden from the dynamic linker, due to
810-
having hidden visibility (on posix) or lacking an import/export annotation (on
811-
windows). If such an object is built into a shared library, each instance
810+
having hidden visibility (on posix) or lacking a dllimport/dllexport attribute
811+
(on windows). If such an object is built into a shared library, each instance
812812
of the library will get its own copy. This can cause very subtle bugs if there was
813813
only supposed to be one copy of the object in question: singletons aren't single,
814814
changes to one object won't affect the others, the object's initializer will run
@@ -817,7 +817,7 @@ once per copy, etc.
817817
Specifically, this warning fires when it detects an object which:
818818
1. Is defined as ``inline`` in a header file (so it might get compiled into multiple libaries), and
819819
2. Has external linkage (otherwise it's supposed to be duplicated), and
820-
3. Has hidden visibility (posix) or lacks an import/export annotation (windows).
820+
3. Has hidden visibility (posix) or lacks a dllimport/dllexport attribute (windows).
821821

822822
As well as one of the following:
823823
1. The object is mutable, or

0 commit comments

Comments
 (0)