[libc++] Remove not needed call to __is_long()

nilayvaish · ldionne · commit d17d89f4eb62 · 2021-11-16T11:26:13.000-05:00
The string is known to be long since __grow_by unconditionally calls __set_long_cap(). Differential Revision: https://reviews.llvm.org/D113910
diff --git a/libcxx/include/string b/libcxx/include/string
@@ -2658,7 +2658,7 @@ basic_string<_CharT, _Traits, _Allocator>::push_back(value_type __c)
     if (__sz == __cap)
     {
         __grow_by(__cap, 1, __sz, __sz, 0);
-        __is_short = !__is_long();
+        __is_short = false;
     }
     pointer __p;
     if (__is_short)

Original file line number	Diff line number	Diff line change
`@@ -2658,7 +2658,7 @@ basic_string<_CharT, _Traits, _Allocator>::push_back(value_type __c)`
`2658`	`2658`	`if (__sz == __cap)`
`2659`	`2659`	`{`
`2660`	`2660`	`__grow_by(__cap, 1, __sz, __sz, 0);`
`2661`		`- __is_short = !__is_long();`
	`2661`	`+ __is_short = false;`
`2662`	`2662`	`}`
`2663`	`2663`	`pointer __p;`
`2664`	`2664`	`if (__is_short)`