Skip to content

Commit d20731c

Browse files
abhishek-kaushik22abhishek-kaushik22
authored
[CGData][GlobalIsel][Legalizer][DAG][MC][AsmParser][X86][AMX] Use std::move to avoid copy (#118068)
1 parent eb49788 commit d20731c

File tree

5 files changed

+27
-27
lines changed

5 files changed

+27
-27
lines changed

‎llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7717,9 +7717,9 @@ bool CombinerHelper::matchShuffleUndefRHS(MachineInstr &MI,
77177717
if (!Changed)
77187718
return false;
77197719

7720-
MatchInfo = [&, NewMask](MachineIRBuilder &B) {
7720+
MatchInfo = [&, NewMask = std::move(NewMask)](MachineIRBuilder &B) {
77217721
B.buildShuffleVector(MI.getOperand(0), MI.getOperand(1), MI.getOperand(2),
7722-
NewMask);
7722+
std::move(NewMask));
77237723
};
77247724

77257725
return true;

‎llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6823,7 +6823,7 @@ SDValue SelectionDAG::FoldConstantArithmetic(unsigned Opcode, const SDLoc &DL,
68236823
ScalarOps.push_back(getUNDEF(OpVT));
68246824
continue;
68256825
}
6826-
APInt Val = cast<ConstantSDNode>(Op)->getAPIntValue();
6826+
const APInt &Val = cast<ConstantSDNode>(Op)->getAPIntValue();
68276827
ScalarOps.push_back(SignExtendInReg(Val, OpVT));
68286828
}
68296829
return getBuildVector(VT, DL, ScalarOps);

‎llvm/lib/MC/MCParser/AsmParser.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6287,7 +6287,7 @@ bool AsmParser::parseMSInlineAsm(
62876287
if (AsmStart != AsmEnd)
62886288
OS << StringRef(AsmStart, AsmEnd - AsmStart);
62896289

6290-
AsmString = AsmStringIR;
6290+
AsmString = std::move(AsmStringIR);
62916291
return false;
62926292
}
62936293

‎llvm/lib/MC/MCStreamer.cpp

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,7 @@ void MCStreamer::emitCFIStartProc(bool IsSimple, SMLoc Loc) {
463463
}
464464

465465
FrameInfoStack.emplace_back(DwarfFrameInfos.size(), getCurrentSectionOnly());
466-
DwarfFrameInfos.push_back(Frame);
466+
DwarfFrameInfos.push_back(std::move(Frame));
467467
}
468468

469469
void MCStreamer::emitCFIStartProcImpl(MCDwarfFrameInfo &Frame) {
@@ -510,7 +510,7 @@ void MCStreamer::emitCFIDefCfa(int64_t Register, int64_t Offset, SMLoc Loc) {
510510
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
511511
if (!CurFrame)
512512
return;
513-
CurFrame->Instructions.push_back(Instruction);
513+
CurFrame->Instructions.push_back(std::move(Instruction));
514514
CurFrame->CurrentCfaRegister = static_cast<unsigned>(Register);
515515
}
516516

@@ -521,7 +521,7 @@ void MCStreamer::emitCFIDefCfaOffset(int64_t Offset, SMLoc Loc) {
521521
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
522522
if (!CurFrame)
523523
return;
524-
CurFrame->Instructions.push_back(Instruction);
524+
CurFrame->Instructions.push_back(std::move(Instruction));
525525
}
526526

527527
void MCStreamer::emitCFIAdjustCfaOffset(int64_t Adjustment, SMLoc Loc) {
@@ -531,7 +531,7 @@ void MCStreamer::emitCFIAdjustCfaOffset(int64_t Adjustment, SMLoc Loc) {
531531
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
532532
if (!CurFrame)
533533
return;
534-
CurFrame->Instructions.push_back(Instruction);
534+
CurFrame->Instructions.push_back(std::move(Instruction));
535535
}
536536

537537
void MCStreamer::emitCFIDefCfaRegister(int64_t Register, SMLoc Loc) {
@@ -541,7 +541,7 @@ void MCStreamer::emitCFIDefCfaRegister(int64_t Register, SMLoc Loc) {
541541
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
542542
if (!CurFrame)
543543
return;
544-
CurFrame->Instructions.push_back(Instruction);
544+
CurFrame->Instructions.push_back(std::move(Instruction));
545545
CurFrame->CurrentCfaRegister = static_cast<unsigned>(Register);
546546
}
547547

@@ -553,7 +553,7 @@ void MCStreamer::emitCFILLVMDefAspaceCfa(int64_t Register, int64_t Offset,
553553
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
554554
if (!CurFrame)
555555
return;
556-
CurFrame->Instructions.push_back(Instruction);
556+
CurFrame->Instructions.push_back(std::move(Instruction));
557557
CurFrame->CurrentCfaRegister = static_cast<unsigned>(Register);
558558
}
559559

@@ -564,7 +564,7 @@ void MCStreamer::emitCFIOffset(int64_t Register, int64_t Offset, SMLoc Loc) {
564564
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
565565
if (!CurFrame)
566566
return;
567-
CurFrame->Instructions.push_back(Instruction);
567+
CurFrame->Instructions.push_back(std::move(Instruction));
568568
}
569569

570570
void MCStreamer::emitCFIRelOffset(int64_t Register, int64_t Offset, SMLoc Loc) {
@@ -574,7 +574,7 @@ void MCStreamer::emitCFIRelOffset(int64_t Register, int64_t Offset, SMLoc Loc) {
574574
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
575575
if (!CurFrame)
576576
return;
577-
CurFrame->Instructions.push_back(Instruction);
577+
CurFrame->Instructions.push_back(std::move(Instruction));
578578
}
579579

580580
void MCStreamer::emitCFIPersonality(const MCSymbol *Sym,
@@ -601,7 +601,7 @@ void MCStreamer::emitCFIRememberState(SMLoc Loc) {
601601
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
602602
if (!CurFrame)
603603
return;
604-
CurFrame->Instructions.push_back(Instruction);
604+
CurFrame->Instructions.push_back(std::move(Instruction));
605605
}
606606

607607
void MCStreamer::emitCFIRestoreState(SMLoc Loc) {
@@ -612,7 +612,7 @@ void MCStreamer::emitCFIRestoreState(SMLoc Loc) {
612612
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
613613
if (!CurFrame)
614614
return;
615-
CurFrame->Instructions.push_back(Instruction);
615+
CurFrame->Instructions.push_back(std::move(Instruction));
616616
}
617617

618618
void MCStreamer::emitCFISameValue(int64_t Register, SMLoc Loc) {
@@ -622,7 +622,7 @@ void MCStreamer::emitCFISameValue(int64_t Register, SMLoc Loc) {
622622
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
623623
if (!CurFrame)
624624
return;
625-
CurFrame->Instructions.push_back(Instruction);
625+
CurFrame->Instructions.push_back(std::move(Instruction));
626626
}
627627

628628
void MCStreamer::emitCFIRestore(int64_t Register, SMLoc Loc) {
@@ -632,7 +632,7 @@ void MCStreamer::emitCFIRestore(int64_t Register, SMLoc Loc) {
632632
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
633633
if (!CurFrame)
634634
return;
635-
CurFrame->Instructions.push_back(Instruction);
635+
CurFrame->Instructions.push_back(std::move(Instruction));
636636
}
637637

638638
void MCStreamer::emitCFIEscape(StringRef Values, SMLoc Loc) {
@@ -642,7 +642,7 @@ void MCStreamer::emitCFIEscape(StringRef Values, SMLoc Loc) {
642642
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
643643
if (!CurFrame)
644644
return;
645-
CurFrame->Instructions.push_back(Instruction);
645+
CurFrame->Instructions.push_back(std::move(Instruction));
646646
}
647647

648648
void MCStreamer::emitCFIGnuArgsSize(int64_t Size, SMLoc Loc) {
@@ -652,7 +652,7 @@ void MCStreamer::emitCFIGnuArgsSize(int64_t Size, SMLoc Loc) {
652652
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
653653
if (!CurFrame)
654654
return;
655-
CurFrame->Instructions.push_back(Instruction);
655+
CurFrame->Instructions.push_back(std::move(Instruction));
656656
}
657657

658658
void MCStreamer::emitCFISignalFrame() {
@@ -669,7 +669,7 @@ void MCStreamer::emitCFIUndefined(int64_t Register, SMLoc Loc) {
669669
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
670670
if (!CurFrame)
671671
return;
672-
CurFrame->Instructions.push_back(Instruction);
672+
CurFrame->Instructions.push_back(std::move(Instruction));
673673
}
674674

675675
void MCStreamer::emitCFIRegister(int64_t Register1, int64_t Register2,
@@ -680,7 +680,7 @@ void MCStreamer::emitCFIRegister(int64_t Register1, int64_t Register2,
680680
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
681681
if (!CurFrame)
682682
return;
683-
CurFrame->Instructions.push_back(Instruction);
683+
CurFrame->Instructions.push_back(std::move(Instruction));
684684
}
685685

686686
void MCStreamer::emitCFIWindowSave(SMLoc Loc) {
@@ -689,7 +689,7 @@ void MCStreamer::emitCFIWindowSave(SMLoc Loc) {
689689
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
690690
if (!CurFrame)
691691
return;
692-
CurFrame->Instructions.push_back(Instruction);
692+
CurFrame->Instructions.push_back(std::move(Instruction));
693693
}
694694

695695
void MCStreamer::emitCFINegateRAState(SMLoc Loc) {
@@ -699,7 +699,7 @@ void MCStreamer::emitCFINegateRAState(SMLoc Loc) {
699699
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
700700
if (!CurFrame)
701701
return;
702-
CurFrame->Instructions.push_back(Instruction);
702+
CurFrame->Instructions.push_back(std::move(Instruction));
703703
}
704704

705705
void MCStreamer::emitCFINegateRAStateWithPC(SMLoc Loc) {
@@ -709,7 +709,7 @@ void MCStreamer::emitCFINegateRAStateWithPC(SMLoc Loc) {
709709
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
710710
if (!CurFrame)
711711
return;
712-
CurFrame->Instructions.push_back(Instruction);
712+
CurFrame->Instructions.push_back(std::move(Instruction));
713713
}
714714

715715
void MCStreamer::emitCFIReturnColumn(int64_t Register) {
@@ -733,7 +733,7 @@ void MCStreamer::emitCFIValOffset(int64_t Register, int64_t Offset, SMLoc Loc) {
733733
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
734734
if (!CurFrame)
735735
return;
736-
CurFrame->Instructions.push_back(Instruction);
736+
CurFrame->Instructions.push_back(std::move(Instruction));
737737
}
738738

739739
WinEH::FrameInfo *MCStreamer::EnsureValidWinFrameInfo(SMLoc Loc) {

‎llvm/lib/Target/X86/X86TileConfig.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ static void collectVirtRegShapes(MachineRegisterInfo *MRI, VirtRegMap &VRM,
103103
unsigned Index = PhysReg - X86::TMM0;
104104
if (!Phys2Shapes[Index].isValid()) {
105105
ShapeT Shape = VRM.getShape(VirtReg);
106-
Phys2Shapes[Index] = Shape;
106+
Phys2Shapes[Index] = std::move(Shape);
107107
return;
108108
}
109109
}
@@ -118,12 +118,12 @@ static void collectVirtRegShapes(MachineRegisterInfo *MRI, VirtRegMap &VRM,
118118

119119
if (!Phys2Shapes[Index0].isValid()) {
120120
ShapeT Shape0(Shape.getRow(0), Shape.getCol(0), MRI);
121-
Phys2Shapes[Index0] = Shape0;
121+
Phys2Shapes[Index0] = std::move(Shape0);
122122
}
123123

124124
if (!Phys2Shapes[Index1].isValid()) {
125125
ShapeT Shape1(Shape.getRow(1), Shape.getCol(1), MRI);
126-
Phys2Shapes[Index1] = Shape1;
126+
Phys2Shapes[Index1] = std::move(Shape1);
127127
}
128128
}
129129
}

0 commit comments

Comments
 (0)