Skip to content

Commit d2398cc

Browse files
authored
Restore: [mlir][ROCDL] Stop setting amdgpu-implicitarg-num-bytes (#79129)
This patch restores PR#78498
1 parent 6b02d2f commit d2398cc

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

mlir/lib/Target/LLVMIR/Dialect/ROCDL/ROCDLToLLVMIRTranslation.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ class ROCDLDialectLLVMIRTranslationInterface
9999
if (!llvmFunc->hasFnAttribute("amdgpu-flat-work-group-size")) {
100100
llvmFunc->addFnAttr("amdgpu-flat-work-group-size", "1,256");
101101
}
102-
llvmFunc->addFnAttr("amdgpu-implicitarg-num-bytes", "256");
102+
103103
}
104104
// Override flat-work-group-size
105105
// TODO: update clients to rocdl.flat_work_group_size instead,

mlir/test/Target/LLVMIR/rocdl.mlir

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ llvm.func @rocdl_8bit_floats(%source: i32, %stoch: i32) -> i32 {
489489
llvm.return %source5 : i32
490490
}
491491

492-
// CHECK-DAG: attributes #[[$KERNEL_ATTRS]] = { "amdgpu-flat-work-group-size"="1,256" "amdgpu-implicitarg-num-bytes"="256" }
492+
// CHECK-DAG: attributes #[[$KERNEL_ATTRS]] = { "amdgpu-flat-work-group-size"="1,256" }
493493
// CHECK-DAG: attributes #[[$KERNEL_WORKGROUP_ATTRS]] = { "amdgpu-flat-work-group-size"="1,1024"
494494
// CHECK-DAG: attributes #[[$KNOWN_BLOCK_SIZE_ATTRS]] = { "amdgpu-flat-work-group-size"="128,128"
495495
// CHECK-DAG: ![[$RANGE]] = !{i32 0, i32 64}

0 commit comments

Comments
 (0)