Skip to content

Commit d30a5fc

Browse files
authored
[NFC][AArch64] Explicitly define undefined bits for instructions (#122129)
Explicitly define bits for the following instructions: * Bit 21 for stltxr/ldatxr (defaults to zero) wasn't defined. * Bits 16-20 for ldaxpx/ldxpx (unpredictable) weren't defined. * Bits 10-14 for smulh/umulh (unpredictable) weren't defined.
1 parent f5cd181 commit d30a5fc

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

llvm/lib/Target/AArch64/AArch64InstrFormats.td

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2770,6 +2770,8 @@ class MulHi<bits<3> opc, string asm, SDNode OpNode>
27702770
let Inst{23-21} = opc;
27712771
let Inst{20-16} = Rm;
27722772
let Inst{15} = 0;
2773+
let Inst{14-10} = 0b11111;
2774+
let Unpredictable{14-10} = 0b11111;
27732775
let Inst{9-5} = Rn;
27742776
let Inst{4-0} = Rd;
27752777

@@ -4922,6 +4924,8 @@ class LoadExclusivePair<bits<2> sz, bit o2, bit L, bit o1, bit o0,
49224924
bits<5> Rt;
49234925
bits<5> Rt2;
49244926
bits<5> Rn;
4927+
let Inst{20-16} = 0b11111;
4928+
let Unpredictable{20-16} = 0b11111;
49254929
let Inst{14-10} = Rt2;
49264930
let Inst{9-5} = Rn;
49274931
let Inst{4-0} = Rt;
@@ -4937,6 +4941,7 @@ class BaseLoadStoreExclusiveLSUI<bits<2> sz, bit L, bit o0,
49374941
let Inst{31-30} = sz;
49384942
let Inst{29-23} = 0b0010010;
49394943
let Inst{22} = L;
4944+
let Inst{21} = 0b0;
49404945
let Inst{15} = o0;
49414946
}
49424947

0 commit comments

Comments
 (0)