add many tests

Author: Yifan Zhu

libc/src/pthread/pthread_rwlock_destroy.cpp

@@ -17,6 +17,8 @@
 namespace LIBC_NAMESPACE {
 
 LLVM_LIBC_FUNCTION(int, pthread_rwlock_destroy, (pthread_rwlock_t * rwlock)) {
+  if (!rwlock)
+    return EINVAL;
   auto *rw = reinterpret_cast<RwLock *>(rwlock);
   RwLock::LockResult res = rw->check_for_destroy();
 

libc/src/pthread/pthread_rwlock_init.cpp

@@ -9,6 +9,7 @@
 #include "src/pthread/pthread_rwlock_init.h"
 
 #include "src/__support/common.h"
+#include "src/__support/libc_assert.h"
 #include "src/__support/threads/linux/rwlock.h"
 
 #include <errno.h>
@@ -33,6 +34,8 @@ LLVM_LIBC_FUNCTION(int, pthread_rwlock_init,
       /*pshared=*/PTHREAD_PROCESS_PRIVATE,
       /*pref*/ PTHREAD_RWLOCK_PREFER_READER_NP,
   };
+  // POSIX does not specify this check, so we add an assertion to catch it.
+  LIBC_ASSERT(rwlock && "rwlock is null");
   if (attr)
     rwlockattr = *attr;
 

libc/src/pthread/pthread_rwlock_rdlock.cpp

@@ -23,6 +23,8 @@ static_assert(
     "as the internal rwlock type.");
 
 LLVM_LIBC_FUNCTION(int, pthread_rwlock_rdlock, (pthread_rwlock_t * rwlock)) {
+  if (!rwlock)
+    return EINVAL;
   RwLock *rw = reinterpret_cast<RwLock *>(rwlock);
   return static_cast<int>(rw->read_lock());
 }

libc/src/pthread/pthread_rwlock_timedrdlock.cpp

@@ -28,6 +28,8 @@ static_assert(
 LLVM_LIBC_FUNCTION(int, pthread_rwlock_timedrdlock,
                    (pthread_rwlock_t * rwlock,
                     const struct timespec *abstime)) {
+  if (!rwlock)
+    return EINVAL;
   RwLock *rw = reinterpret_cast<RwLock *>(rwlock);
   LIBC_ASSERT(abstime && "timedrdlock called with a null timeout");
   auto timeout =

libc/src/pthread/pthread_rwlock_timedwrlock.cpp

@@ -22,6 +22,8 @@ namespace LIBC_NAMESPACE {
 LLVM_LIBC_FUNCTION(int, pthread_rwlock_timedwrlock,
                    (pthread_rwlock_t *__restrict rwlock,
                     const struct timespec *__restrict abstime)) {
+  if (!rwlock)
+    return EINVAL;
   RwLock *rw = reinterpret_cast<RwLock *>(rwlock);
   LIBC_ASSERT(abstime && "timedwrlock called with a null timeout");
   auto timeout =

libc/src/pthread/pthread_rwlock_tryrdlock.cpp

@@ -23,6 +23,8 @@ static_assert(
     "as the internal rwlock type.");
 
 LLVM_LIBC_FUNCTION(int, pthread_rwlock_tryrdlock, (pthread_rwlock_t * rwlock)) {
+  if (!rwlock)
+    return EINVAL;
   RwLock *rw = reinterpret_cast<RwLock *>(rwlock);
   return static_cast<int>(rw->try_read_lock());
 }

libc/src/pthread/pthread_rwlock_trywrlock.cpp

@@ -23,6 +23,8 @@ static_assert(
     "as the internal rwlock type.");
 
 LLVM_LIBC_FUNCTION(int, pthread_rwlock_trywrlock, (pthread_rwlock_t * rwlock)) {
+  if (!rwlock)
+    return EINVAL;
   RwLock *rw = reinterpret_cast<RwLock *>(rwlock);
   return static_cast<int>(rw->try_write_lock());
 }

libc/src/pthread/pthread_rwlock_unlock.cpp

@@ -17,6 +17,8 @@
 namespace LIBC_NAMESPACE {
 
 LLVM_LIBC_FUNCTION(int, pthread_rwlock_unlock, (pthread_rwlock_t * rwlock)) {
+  if (!rwlock)
+    return EINVAL;
   auto *rw = reinterpret_cast<RwLock *>(rwlock);
   return static_cast<int>(rw->unlock());
 }

libc/src/pthread/pthread_rwlock_wrlock.cpp

@@ -23,6 +23,8 @@ static_assert(
     "as the internal rwlock type.");
 
 LLVM_LIBC_FUNCTION(int, pthread_rwlock_wrlock, (pthread_rwlock_t * rwlock)) {
+  if (!rwlock)
+    return EINVAL;
   RwLock *rw = reinterpret_cast<RwLock *>(rwlock);
   return static_cast<int>(rw->write_lock());
 }

libc/test/integration/src/pthread/CMakeLists.txt

@@ -38,8 +38,19 @@ add_integration_test(
     libc.src.pthread.pthread_rwlock_unlock
     libc.src.pthread.pthread_create
     libc.src.pthread.pthread_join
+    libc.src.pthread.pthread_rwlockattr_init
+    libc.src.pthread.pthread_rwlockattr_destroy
+    libc.src.pthread.pthread_rwlockattr_setpshared
+    libc.src.pthread.pthread_rwlockattr_setkind_np
+    libc.src.sys.mman.mmap
+    libc.src.sys.mman.munmap
     libc.src.time.clock_gettime
+    libc.src.sys.random.getrandom
     libc.src.unistd.fork
+    libc.src.sys.wait.waitpid
+    libc.src.stdlib.exit
+    libc.src.__support.CPP.atomic
+    libc.src.__support.threads.sleep
 )
 
 add_integration_test(