Skip to content

Commit d479f0d

Browse files
committed
Address code review comments
1 parent ee9c92f commit d479f0d

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,12 @@ class CIRBaseBuilderTy : public mlir::OpBuilder {
3434

3535
cir::ConstantOp getConstantInt(mlir::Location loc, mlir::Type ty,
3636
int64_t value) {
37-
return create<cir::ConstantOp>(loc, ty, cir::IntAttr::get(ty, value));
37+
return getConstant(loc, cir::IntAttr::get(ty, value));
3838
}
3939

4040
// Creates constant null value for integral type ty.
4141
cir::ConstantOp getNullValue(mlir::Type ty, mlir::Location loc) {
42-
return create<cir::ConstantOp>(loc, ty, getZeroInitAttr(ty));
42+
return getConstant(loc, getZeroInitAttr(ty));
4343
}
4444

4545
cir::ConstantOp getBool(bool state, mlir::Location loc) {

clang/include/clang/CIR/Dialect/IR/CIROps.td

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,8 +258,8 @@ def PtrStrideOp : CIR_Op<"ptr_stride",
258258
let results = (outs CIR_PointerType:$result);
259259

260260
let assemblyFormat = [{
261-
`(` $base `:` qualified(type($base)) `,` $stride `:` qualified(type($stride)) `)`
262-
`,` qualified(type($result)) attr-dict
261+
`(` $base `:` qualified(type($base)) `,` $stride `:`
262+
qualified(type($stride)) `)` `,` qualified(type($result)) attr-dict
263263
}];
264264

265265
let extraClassDeclaration = [{

0 commit comments

Comments
 (0)