Skip to content

Commit d545001

Browse files
committed
fixup! fixup! [docs] Update docs on code-review process
Remove paragraph from Contributing.rst
1 parent 3714f26 commit d545001

File tree

1 file changed

+3
-15
lines changed

1 file changed

+3
-15
lines changed

llvm/docs/Contributing.rst

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -102,21 +102,9 @@ will not be able to select reviewers in such a way, in which case you can still
102102
get the attention of potential reviewers by CC'ing them in a comment -- just
103103
@name them.
104104

105-
A reviewer may request changes or ask questions during the review. If you are
106-
uncertain on how to provide test cases, documentation, etc., feel free to ask
107-
for guidance during the review. Please address the feedback and re-post an
108-
updated version of your patch. This cycle continues until all requests and comments
109-
have been addressed and a reviewer accepts the patch with a `Looks good to me` or `LGTM`.
110-
Once that is done the change can be committed. If you do not have commit
111-
access, please let people know during the review and someone should commit it
112-
on your behalf.
113-
114-
If you have received no comments on your patch for a week, you can request a
115-
review by 'ping'ing the GitHub PR with "Ping". The common courtesy 'ping' rate
116-
is once a week. Please remember that you are asking for valuable time from other
117-
professional developers.
118-
119-
For more information on LLVM's code-review process, please see :doc:`CodeReview`.
105+
If you do not have commit access, please let people know during the review and
106+
someone should commit it on your behalf once it has been accepted. For more
107+
information on LLVM's code-review process, please see :doc:`CodeReview`.
120108

121109
.. _commit_from_git:
122110

0 commit comments

Comments
 (0)