Skip to content

Commit d56f517

Browse files
authored
[mlir][LLVM] Add support for invariant group related intrinsics (#115877)
This PR adds support for the following LLVM intrinsics: - `llvm.launder.invariant.group` - `llvm.strip.invariant.group`
1 parent 91e134a commit d56f517

File tree

6 files changed

+84
-0
lines changed

6 files changed

+84
-0
lines changed

mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -346,6 +346,24 @@ def LLVM_InvariantEndOp : LLVM_ZeroResultIntrOp<"invariant.end", [2],
346346
"qualified(type($ptr))";
347347
}
348348

349+
def LLVM_LaunderInvariantGroupOp
350+
: LLVM_OneResultIntrOp<"launder.invariant.group", [], [0],
351+
[DeclareOpInterfaceMethods<PromotableOpInterface>,
352+
SameOperandsAndResultType]> {
353+
let arguments = (ins LLVM_AnyPointer:$ptr);
354+
let results = (outs LLVM_AnyPointer:$res);
355+
let assemblyFormat = "$ptr attr-dict `:` qualified(type($ptr))";
356+
}
357+
358+
def LLVM_StripInvariantGroupOp
359+
: LLVM_OneResultIntrOp<"strip.invariant.group", [], [0],
360+
[DeclareOpInterfaceMethods<PromotableOpInterface>,
361+
SameOperandsAndResultType]> {
362+
let arguments = (ins LLVM_AnyPointer:$ptr);
363+
let results = (outs LLVM_AnyPointer:$res);
364+
let assemblyFormat = "$ptr attr-dict `:` qualified(type($ptr))";
365+
}
366+
349367
// Constrained Floating-Point Intrinsics.
350368

351369
class LLVM_ConstrainedIntr<string mnem, int numArgs,

mlir/lib/Dialect/LLVMIR/IR/LLVMMemorySlot.cpp

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -590,6 +590,30 @@ DeletionKind LLVM::InvariantEndOp::removeBlockingUses(
590590
return DeletionKind::Delete;
591591
}
592592

593+
bool LLVM::LaunderInvariantGroupOp::canUsesBeRemoved(
594+
const SmallPtrSetImpl<OpOperand *> &blockingUses,
595+
SmallVectorImpl<OpOperand *> &newBlockingUses,
596+
const DataLayout &dataLayout) {
597+
return forwardToUsers(*this, newBlockingUses);
598+
}
599+
600+
DeletionKind LLVM::LaunderInvariantGroupOp::removeBlockingUses(
601+
const SmallPtrSetImpl<OpOperand *> &blockingUses, OpBuilder &builder) {
602+
return DeletionKind::Delete;
603+
}
604+
605+
bool LLVM::StripInvariantGroupOp::canUsesBeRemoved(
606+
const SmallPtrSetImpl<OpOperand *> &blockingUses,
607+
SmallVectorImpl<OpOperand *> &newBlockingUses,
608+
const DataLayout &dataLayout) {
609+
return forwardToUsers(*this, newBlockingUses);
610+
}
611+
612+
DeletionKind LLVM::StripInvariantGroupOp::removeBlockingUses(
613+
const SmallPtrSetImpl<OpOperand *> &blockingUses, OpBuilder &builder) {
614+
return DeletionKind::Delete;
615+
}
616+
593617
bool LLVM::DbgDeclareOp::canUsesBeRemoved(
594618
const SmallPtrSetImpl<OpOperand *> &blockingUses,
595619
SmallVectorImpl<OpOperand *> &newBlockingUses,

mlir/test/Dialect/LLVMIR/mem2reg.mlir

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -414,6 +414,18 @@ llvm.func @ignore_lifetime() {
414414

415415
// -----
416416

417+
// CHECK-LABEL: llvm.func @ignore_invariant_group
418+
// CHECK-NOT: llvm.alloca
419+
llvm.func @ignore_invariant_group() {
420+
%0 = llvm.mlir.constant(1 : i32) : i32
421+
%1 = llvm.alloca %0 x i32 {alignment = 4 : i64} : (i32) -> !llvm.ptr
422+
%2 = llvm.intr.launder.invariant.group %1 : !llvm.ptr
423+
%3 = llvm.intr.strip.invariant.group %2 : !llvm.ptr
424+
llvm.return
425+
}
426+
427+
// -----
428+
417429
// CHECK-LABEL: llvm.func @ignore_discardable_tree
418430
// CHECK-NOT: = llvm.alloca
419431
llvm.func @ignore_discardable_tree() {

mlir/test/Dialect/LLVMIR/roundtrip.mlir

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -686,6 +686,16 @@ llvm.func @invariant(%p: !llvm.ptr) {
686686
llvm.return
687687
}
688688

689+
// CHECK-LABEL: @invariant_group_intrinsics
690+
// CHECK-SAME: %[[P:.+]]: !llvm.ptr
691+
llvm.func @invariant_group_intrinsics(%p: !llvm.ptr) {
692+
// CHECK: %{{.+}} = llvm.intr.launder.invariant.group %[[P]] : !llvm.ptr
693+
%1 = llvm.intr.launder.invariant.group %p : !llvm.ptr
694+
// CHECK: %{{.+}} = llvm.intr.strip.invariant.group %[[P]] : !llvm.ptr
695+
%2 = llvm.intr.strip.invariant.group %p : !llvm.ptr
696+
llvm.return
697+
}
698+
689699
// CHECK-LABEL: @vararg_func
690700
llvm.func @vararg_func(%arg0: i32, ...) {
691701
// CHECK: %[[C:.*]] = llvm.mlir.constant(1 : i32)

mlir/test/Target/LLVMIR/Import/intrinsic.ll

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -806,6 +806,15 @@ define void @invariant(ptr %0) {
806806
ret void
807807
}
808808

809+
; CHECK-LABEL: llvm.func @invariant_group
810+
define void @invariant_group(ptr %0) {
811+
; CHECK: %{{.+}} = llvm.intr.launder.invariant.group %{{.*}} : !llvm.ptr
812+
%2 = call ptr @llvm.launder.invariant.group.p0(ptr %0)
813+
; CHECK: %{{.+}} = llvm.intr.strip.invariant.group %{{.*}} : !llvm.ptr
814+
%3 = call ptr @llvm.strip.invariant.group.p0(ptr %0)
815+
ret void
816+
}
817+
809818
; CHECK-LABEL: llvm.func @vector_insert
810819
define void @vector_insert(<vscale x 4 x float> %0, <4 x float> %1) {
811820
; CHECK: llvm.intr.vector.insert %{{.*}}, %{{.*}}[4] : vector<4xf32> into !llvm.vec<? x 4 x f32>
@@ -1195,6 +1204,8 @@ declare void @llvm.lifetime.start.p0(i64 immarg, ptr nocapture)
11951204
declare void @llvm.lifetime.end.p0(i64 immarg, ptr nocapture)
11961205
declare ptr @llvm.invariant.start.p0(i64 immarg, ptr nocapture)
11971206
declare void @llvm.invariant.end.p0(ptr, i64 immarg, ptr nocapture)
1207+
declare ptr @llvm.launder.invariant.group.p0(ptr nocapture)
1208+
declare ptr @llvm.strip.invariant.group.p0(ptr nocapture)
11981209

11991210
declare void @llvm.assume(i1)
12001211
declare float @llvm.ssa.copy.f32(float returned)

mlir/test/Target/LLVMIR/llvmir-intrinsics.mlir

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1024,6 +1024,15 @@ llvm.func @invariant(%p: !llvm.ptr) {
10241024
llvm.return
10251025
}
10261026

1027+
// CHECK-LABEL: @invariant_group
1028+
llvm.func @invariant_group(%p: !llvm.ptr) {
1029+
// CHECK: call ptr @llvm.launder.invariant.group
1030+
%1 = llvm.intr.launder.invariant.group %p : !llvm.ptr
1031+
// CHECK: call ptr @llvm.strip.invariant.group
1032+
%2 = llvm.intr.strip.invariant.group %p : !llvm.ptr
1033+
llvm.return
1034+
}
1035+
10271036
// CHECK-LABEL: @ssa_copy
10281037
llvm.func @ssa_copy(%arg: f32) -> f32 {
10291038
// CHECK: call float @llvm.ssa.copy

0 commit comments

Comments
 (0)