Add variables as options using ODS

Author: erman-gurses

mlir/include/mlir/Dialect/AMDGPU/Transforms/Passes.td

@@ -37,10 +37,17 @@ def OptimizeSharedMemory : Pass<"amdgpu-optimize-shared-memory"> {
     attempts to optimize reads/writes from a memref representing GPU shared
     memory in order to avoid bank conflicts.
   }];
-
   let dependentDialects = [
     "memref::MemRefDialect", "vector::VectorDialect"
   ];
+  let options = [
+    Option<"sharedMemoryLineSizeBytes", "shared-memory-line-size-bytes", "uint64_t",
+           /*default=*/"128",
+           "Shared memory line size in bytes">,
+    Option<"defaultVectorSizeBits", "default-vector-size-bits", "uint64_t",
+           /*default=*/"128",
+           "Default vector size in bits">,
+  ];
 }
 
 #endif // MLIR_DIALECT_AMDGPU_TRANSFORMS_PASSES_TD_

mlir/lib/Dialect/AMDGPU/Transforms/OptimizeSharedMemory.cpp

@@ -149,7 +149,6 @@ getShmReadAndWriteOps(Operation *parentOp, Value shmMemRef,
 LogicalResult amdgpu::optimizeSharedMemoryReadsAndWrites(
     Operation *parentOp, Value memrefValue, int64_t sharedMemoryLineSizeBytes,
     int64_t defaultVectorSizeBits) {
-
   auto memRefType = dyn_cast<MemRefType>(memrefValue.getType());
   if (!memRefType ||
       !amdgpu::AMDGPUDialect::hasSharedMemoryAddressSpace(memRefType))
@@ -239,20 +238,12 @@ amdgpu::optimizeSharedMemoryReadsAndWritesOp(func::FuncOp funcOp,
 
 struct OptimizeSharedMemoryPass
     : public amdgpu::impl::OptimizeSharedMemoryBase<OptimizeSharedMemoryPass> {
-
 public:
-  OptimizeSharedMemoryPass()
-      : OptimizeSharedMemoryBase(),
-        sharedMemoryLineSizeBytes(sharedMemoryLineSizeBytes = 128),
-        defaultVectorSizeBits(defaultVectorSizeBits = 128){};
-
-  OptimizeSharedMemoryPass(int64_t sharedMemoryLineSizeBytes,
-                           int64_t defaultVectorSizeBits)
-      : OptimizeSharedMemoryBase(),
-        sharedMemoryLineSizeBytes(sharedMemoryLineSizeBytes),
-        defaultVectorSizeBits(defaultVectorSizeBits){};
-
+  OptimizeSharedMemoryPass() = default;
+  OptimizeSharedMemoryPass(const OptimizeSharedMemoryOptions &options)
+      : OptimizeSharedMemoryBase(options) {}
   void runOnOperation() override {
+
     Operation *op = getOperation();
     SmallVector<memref::AllocOp> shmAllocOps;
     op->walk([&](memref::AllocOp allocOp) {
@@ -268,8 +259,4 @@ struct OptimizeSharedMemoryPass
         return;
     }
   }
-
-private:
-  int64_t sharedMemoryLineSizeBytes;
-  int64_t defaultVectorSizeBits;
 };