Skip to content

Commit d86a937

Browse files
[Orc][examples] Drop target triple from input for remote debugging test (#74831)
#74764 reported that the `lljit-with-remote-debugging` test fails on AArch64 hosts, because the input IR file states arch x86_64 explicitly. In order to drop the target triple we have to remove a check in the example implementation. Not sure it's fully portable now, but at least it's better than before.
1 parent e837ef9 commit d86a937

File tree

2 files changed

+4
-13
lines changed

2 files changed

+4
-13
lines changed

llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/LLJITWithRemoteDebugging.cpp

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@
8888
#include "llvm/Support/InitLLVM.h"
8989
#include "llvm/Support/TargetSelect.h"
9090
#include "llvm/Support/raw_ostream.h"
91+
#include "llvm/TargetParser/Host.h"
9192

9293
#include "../ExampleModules.h"
9394
#include "RemoteJITUtils.h"
@@ -173,24 +174,15 @@ int main(int argc, char *argv[]) {
173174
TSMs.push_back(ExitOnErr(parseExampleModuleFromFile(Path)));
174175
}
175176

176-
StringRef TT;
177+
std::string TT;
177178
StringRef MainModuleName;
178179
TSMs.front().withModuleDo([&MainModuleName, &TT](Module &M) {
179180
MainModuleName = M.getName();
180181
TT = M.getTargetTriple();
182+
if (TT.empty())
183+
TT = sys::getProcessTriple();
181184
});
182185

183-
for (const ThreadSafeModule &TSM : TSMs)
184-
ExitOnErr(TSM.withModuleDo([TT, MainModuleName](Module &M) -> Error {
185-
if (M.getTargetTriple() != TT)
186-
return make_error<StringError>(
187-
formatv("Different target triples in input files:\n"
188-
" '{0}' in '{1}'\n '{2}' in '{3}'",
189-
TT, MainModuleName, M.getTargetTriple(), M.getName()),
190-
inconvertibleErrorCode());
191-
return Error::success();
192-
}));
193-
194186
// Create a target machine that matches the input triple.
195187
JITTargetMachineBuilder JTMB((Triple(TT)));
196188
JTMB.setCodeModel(CodeModel::Small);

llvm/test/Examples/OrcV2Examples/Inputs/argc_sub1_elf.ll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
; ModuleID = 'argc_sub1.c'
2-
target triple = "x86_64-unknown-unknown-elf"
32

43
define i32 @sub1(i32) !dbg !8 {
54
call void @llvm.dbg.value(metadata i32 %0, metadata !13, metadata !DIExpression()), !dbg !14

0 commit comments

Comments
 (0)