Skip to content

Commit d882670

Browse files
authored
Revert "[llvm][StackProtector] Add noreturn to __stack_chk_fail call" (#144452)
Reverts #143976 Reverting since this broke a builder: https://lab.llvm.org/buildbot/#/builders/190/builds/21563
1 parent ac7af53 commit d882670

File tree

3 files changed

+2
-56
lines changed

3 files changed

+2
-56
lines changed

llvm/lib/CodeGen/StackProtector.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -725,8 +725,8 @@ BasicBlock *CreateFailBB(Function *F, const Triple &Trip) {
725725
StackChkFail =
726726
M->getOrInsertFunction("__stack_chk_fail", Type::getVoidTy(Context));
727727
}
728-
CallInst *Call = B.CreateCall(StackChkFail, Args);
729-
Call->addFnAttr(Attribute::NoReturn);
728+
cast<Function>(StackChkFail.getCallee())->addFnAttr(Attribute::NoReturn);
729+
B.CreateCall(StackChkFail, Args);
730730
B.CreateUnreachable();
731731
return FailBB;
732732
}

llvm/test/Transforms/StackProtector/cross-dso-cfi-stack-chk-fail.ll

Lines changed: 0 additions & 33 deletions
This file was deleted.

llvm/test/Transforms/StackProtector/stack-chk-fail-alias.ll

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)