Skip to content

Commit d93a126

Browse files
authored
[lldb] Add ability to detect darwin host linker version to xfail tests (#83941)
When Apple released its new linker, it had a subtle bug that caused LLDB's TLS tests to fail. Unfortunately this means that TLS tests are not going to work on machines that have affected versions of the linker, so we should annotate the tests so that they only work when we are confident the linker has the required fix. I'm not completely satisfied with this implementation. That being said, I believe that adding suport for linker versions in general is a non-trivial change that would require far more thought. There are a few challenges involved: - LLDB's testing infra takes an argument to change the compiler, but there's no way to switch out the linker. - There's no standard way to ask a compiler what linker it will use. - There's no standard way to ask a linker what its version is. Many platforms have the same name for their linker (ld). - Some platforms automatically switch out the linker underneath you. We do this for Windows tests (where we use LLD no matter what). Given that this is affecting the tests on our CI, I think this is an acceptable solution in the interim.
1 parent 909ab0e commit d93a126

File tree

2 files changed

+28
-0
lines changed

2 files changed

+28
-0
lines changed

lldb/packages/Python/lldbsuite/test/lldbplatformutil.py

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
# System modules
55
import itertools
6+
import json
67
import re
78
import subprocess
89
import sys
@@ -16,6 +17,7 @@
1617
from . import lldbtest_config
1718
import lldbsuite.test.lldbplatform as lldbplatform
1819
from lldbsuite.test.builders import get_builder
20+
from lldbsuite.test.lldbutil import is_exe
1921

2022

2123
def check_first_register_readable(test_case):
@@ -333,3 +335,28 @@ def expectedCompiler(compilers):
333335
return True
334336

335337
return False
338+
339+
340+
# This is a helper function to determine if a specific version of Xcode's linker
341+
# contains a TLS bug. We want to skip TLS tests if they contain this bug, but
342+
# adding a linker/linker_version conditions to a decorator is challenging due to
343+
# the number of ways linkers can enter the build process.
344+
def xcode15LinkerBug():
345+
"""Returns true iff a test is running on a darwin platform and the host linker is between versions 1000 and 1109."""
346+
darwin_platforms = lldbplatform.translate(lldbplatform.darwin_all)
347+
if getPlatform() not in darwin_platforms:
348+
return False
349+
350+
try:
351+
raw_version_details = subprocess.check_output(
352+
("xcrun", "ld", "-version_details")
353+
)
354+
version_details = json.loads(raw_version_details)
355+
version = version_details.get("version", "0")
356+
version_tuple = tuple(int(x) for x in version.split("."))
357+
if (1000,) <= version_tuple <= (1109,):
358+
return True
359+
except:
360+
pass
361+
362+
return False

lldb/test/API/lang/c/tls_globals/TestTlsGlobals.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ def setUp(self):
4040
@skipIfWindows
4141
@skipIf(oslist=["linux"], archs=["arm", "aarch64"])
4242
@skipIf(oslist=no_match([lldbplatformutil.getDarwinOSTriples(), "linux"]))
43+
@expectedFailureIf(lldbplatformutil.xcode15LinkerBug())
4344
def test(self):
4445
"""Test thread-local storage."""
4546
self.build()

0 commit comments

Comments
 (0)