[clang][dataflow] Remove deprecated synonyms related to RecordStorageLocation and RecordValue

Reviewed By: ymandel, xazax.hun

Differential Revision: https://reviews.llvm.org/D159264

Author: martinboehme

clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h

@@ -690,15 +690,6 @@ RecordValue &refreshRecordValue(RecordStorageLocation &Loc, Environment &Env);
 /// See also documentation for the overload above.
 RecordValue &refreshRecordValue(const Expr &Expr, Environment &Env);
 
-/// Deprecated synonym for `refreshRecordValue()`.
-inline RecordValue &refreshStructValue(RecordStorageLocation &Loc,
-                                       Environment &Env) {
-  return refreshRecordValue(Loc, Env);
-}
-inline RecordValue &refreshStructValue(const Expr &Expr, Environment &Env) {
-  return refreshRecordValue(Expr, Env);
-}
-
 } // namespace dataflow
 } // namespace clang
 

clang/include/clang/Analysis/FlowSensitive/StorageLocation.h

@@ -34,8 +34,6 @@ class StorageLocation {
   enum class Kind {
     Scalar,
     Record,
-    // Deprecated synonym for `Record`
-    Aggregate = Record,
   };
 
   StorageLocation(Kind LocKind, QualType Type) : LocKind(LocKind), Type(Type) {
@@ -155,9 +153,6 @@ class RecordStorageLocation final : public StorageLocation {
   FieldToLoc Children;
 };
 
-/// Deprecated synonym for `RecordStorageLocation`.
-using AggregateStorageLocation = RecordStorageLocation;
-
 } // namespace dataflow
 } // namespace clang
 

clang/include/clang/Analysis/FlowSensitive/Value.h

@@ -36,8 +36,6 @@ class Value {
     Integer,
     Pointer,
     Record,
-    // Deprecated synonym for `Record`
-    Struct = Record,
 
     // TODO: Top values should not be need to be type-specific.
     TopBool,
@@ -227,9 +225,6 @@ class RecordValue final : public Value {
   /// Returns the storage location that this `RecordValue` is associated with.
   RecordStorageLocation &getLoc() const { return Loc; }
 
-  /// Deprecated synonym for `getLoc()`.
-  RecordStorageLocation &getAggregateLoc() const { return Loc; }
-
   /// Convenience function that returns the child storage location for `Field`.
   /// See also the documentation for `RecordStorageLocation::getChild()`.
   StorageLocation *getChild(const ValueDecl &Field) const {
@@ -240,9 +235,6 @@ class RecordValue final : public Value {
   RecordStorageLocation &Loc;
 };
 
-/// Deprecated synonym for `RecordValue`.
-using StructValue = RecordValue;
-
 raw_ostream &operator<<(raw_ostream &OS, const Value &Val);
 
 } // namespace dataflow