Skip to content

Commit d97edec

Browse files
committed
address review comments
1 parent 531ce38 commit d97edec

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

mlir/lib/Dialect/LLVMIR/IR/LLVMMemorySlot.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,9 +235,8 @@ static Value castSameSizedTypes(RewriterBase &rewriter, Location loc,
235235
}
236236

237237
/// Constructs operations that convert `srcValue` into a new value of type
238-
/// `targetType`. Performs bitlevel extraction if the source type is larger than
239-
/// the target type.
240-
/// Assumes that this conversion is possible.
238+
/// `targetType`. Performs bit-level extraction if the source type is larger
239+
/// than the target type. Assumes that this conversion is possible.
241240
static Value createExtractAndCast(RewriterBase &rewriter, Location loc,
242241
Value srcValue, Type targetType,
243242
const DataLayout &dataLayout) {

mlir/lib/Transforms/Mem2Reg.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,8 @@ class MemorySlotPromoter {
196196
MemorySlot slot;
197197
PromotableAllocationOpInterface allocator;
198198
RewriterBase &rewriter;
199-
/// Potentially non-initialized default value. Use `getLazyDefaultValue` to
200-
/// initialize it on demand.
199+
/// Potentially non-initialized default value. Use `getOrCreateDefaultValue`
200+
/// to initialize it on demand.
201201
Value defaultValue;
202202
/// Contains the reaching definition at this operation. Reaching definitions
203203
/// are only computed for promotable memory operations with blocking uses.

0 commit comments

Comments
 (0)