[NFC] Change strcpy to std::copy

mu5tafazade · nikic · commit d9b3a9442530 · 2023-03-21T09:44:23.000+01:00
Differential Revision: https://reviews.llvm.org/D146382
diff --git a/llvm/lib/Object/COFFImportFile.cpp b/llvm/lib/Object/COFFImportFile.cpp
@@ -86,7 +86,8 @@ static void writeStringTable(std::vector<uint8_t> &B,
 
   for (const auto &S : Strings) {
     B.resize(Pos + S.length() + 1);
-    strcpy(reinterpret_cast<char *>(&B[Pos]), S.c_str());
+    std::copy(S.begin(), S.end(), std::next(B.begin(), Pos));
+    B[Pos + S.length()] = 0;
     Pos += S.length() + 1;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,8 @@ static void writeStringTable(std::vector<uint8_t> &B,`
`86`	`86`
`87`	`87`	`for (const auto &S : Strings) {`
`88`	`88`	`B.resize(Pos + S.length() + 1);`
`89`		`- strcpy(reinterpret_cast<char *>(&B[Pos]), S.c_str());`
	`89`	`+ std::copy(S.begin(), S.end(), std::next(B.begin(), Pos));`
	`90`	`+ B[Pos + S.length()] = 0;`
`90`	`91`	`Pos += S.length() + 1;`
`91`	`92`	`}`
`92`	`93`