Review feedback

Author: RossBrunton

offload/liboffload/include/OffloadImpl.hpp

@@ -72,9 +72,9 @@ ErrSetT &errors();
 namespace {
 ol_errc_t GetErrorCode(std::error_code Code) {
   if (Code.category() ==
-      error::make_error_code(error::ErrorCode::SUCCESS).category()) {
+      error::make_error_code(error::ErrorCode::SUCCESS).category())
     return static_cast<ol_errc_t>(Code.value());
-  }
+
   return OL_ERRC_UNKNOWN;
 }
 } // namespace

offload/tools/offload-tblgen/EntryPointGen.cpp

@@ -44,7 +44,7 @@ static void EmitValidationFunc(const FunctionRec &F, raw_ostream &OS) {
         OS << formatv(TAB_2 "if ({0}) {{\n", ConditionString);
         OS << formatv(TAB_3 "return createOffloadError(error::ErrorCode::{0}, "
                             "\"validation failure: {1}\");\n",
-                      Return.getEtorValue(), ConditionString);
+                      Return.getUnprefixedValue(), ConditionString);
         OS << TAB_2 "}\n\n";
       }
     }

offload/tools/offload-tblgen/RecordTypes.hpp

@@ -186,7 +186,7 @@ class ReturnRec {
   StringRef getValue() const { return rec->getValueAsString("value"); }
   // Strip the "OL_ERRC_" from the value, resulting in just "FOO" from
   // "OL_ERRC_FOO"
-  StringRef getEtorValue() const {
+  StringRef getUnprefixedValue() const {
     constexpr const char *ERRC = "ERRC_";
     auto Start = getValue().find(ERRC) + strlen(ERRC);
     return getValue().substr(Start);