Skip to content

Commit da6089d

Browse files
committed
remove debug leftover and test fixes based on #78302
1 parent 1b908ad commit da6089d

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

flang/include/flang/Runtime/execute.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ void RTNAME(ExecuteCommandLine)(const Descriptor &command, bool wait = true,
2323
const Descriptor *exitstat = nullptr, const Descriptor *cmdstat = nullptr,
2424
const Descriptor *cmdmsg = nullptr, const char *sourceFile = nullptr,
2525
int line = 0);
26-
2726
}
2827
} // namespace Fortran::runtime
2928

flang/runtime/execute.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@
2525
#include <unistd.h>
2626
#endif
2727

28-
#include <stdio.h>
29-
3028
namespace Fortran::runtime {
3129

3230
// cmdstat specified in 16.9.73
@@ -128,7 +126,6 @@ void RTNAME(ExecuteCommandLine)(const Descriptor &command, bool wait,
128126

129127
if (cmdstat) {
130128
RUNTIME_CHECK(terminator, IsValidIntDescriptor(cmdstat));
131-
printf("cmdstat found. \n");
132129
// Assigned 0 as specifed in standard, if error then overwrite
133130
StoreIntToDescriptor(cmdstat, CMD_EXECUTED, terminator);
134131
}

flang/unittests/Runtime/CommandTest.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -386,8 +386,8 @@ TEST_F(ZeroArguments, ECLValidCommandAndExitStatNoChangeAndCMDStatusSetAsync) {
386386
RTNAME(ExecuteCommandLine)
387387
(*command.get(), wait, exitStat.get(), cmdStat.get(), cmdMsg.get());
388388

389-
CheckDescriptorEqInt(exitStat.get(), 404);
390-
CheckDescriptorEqInt(cmdStat.get(), 0);
389+
CheckDescriptorEqInt<std::int64_t>(exitStat.get(), 404);
390+
CheckDescriptorEqInt<std::int64_t>(cmdStat.get(), 0);
391391
CheckDescriptorEqStr(cmdMsg.get(), "No change");
392392
}
393393

@@ -400,7 +400,7 @@ TEST_F(ZeroArguments, ECLInvalidCommandParentNotTerminatedAsync) {
400400
EXPECT_NO_FATAL_FAILURE(RTNAME(ExecuteCommandLine)(
401401
*command.get(), wait, exitStat.get(), nullptr, cmdMsg.get()));
402402

403-
CheckDescriptorEqInt(exitStat.get(), 404);
403+
CheckDescriptorEqInt<std::int64_t>(exitStat.get(), 404);
404404
CheckDescriptorEqStr(cmdMsg.get(), "No change");
405405
}
406406

@@ -415,7 +415,7 @@ TEST_F(ZeroArguments, SystemValidCommandExitStat) {
415415

416416
RTNAME(ExecuteCommandLine)
417417
(*command.get(), wait, exitStat.get(), cmdStat.get(), nullptr);
418-
CheckDescriptorEqInt(exitStat.get(), 0);
418+
CheckDescriptorEqInt<std::int64_t>(exitStat.get(), 0);
419419
}
420420

421421
TEST_F(ZeroArguments, SystemInvalidCommandExitStat) {
@@ -430,9 +430,9 @@ TEST_F(ZeroArguments, SystemInvalidCommandExitStat) {
430430
RTNAME(ExecuteCommandLine)
431431
(*command.get(), wait, exitStat.get(), cmdStat.get(), nullptr);
432432
#ifdef _WIN32
433-
CheckDescriptorEqInt(exitStat.get(), 1);
433+
CheckDescriptorEqInt<std::int64_t>(exitStat.get(), 1);
434434
#else
435-
CheckDescriptorEqInt(exitStat.get(), 127);
435+
CheckDescriptorEqInt<std::int64_t>(exitStat.get(), 127);
436436
#endif
437437
}
438438

0 commit comments

Comments
 (0)