Skip to content

Commit dab5535

Browse files
committed
Remove TODO, already mentioned in docs
1 parent 6e92fe4 commit dab5535

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3754,15 +3754,6 @@ void OpEmitter::genTypeInterfaceMethods() {
37543754
body << " " << op.getCppClassName()
37553755
<< "::Adaptor adaptor(operands, attributes, properties, regions);\n";
37563756

3757-
// TODO: Ideally, we should be doing some sort of verification here. This
3758-
// is however problemetic due to 2 reasons:
3759-
//
3760-
// 1. Adaptor::verify only verifies attributes. It really should verify
3761-
// if the number of given attributes is right too.
3762-
// 2. PDL passes empty properties to inferReturnTypes, which does not verify.
3763-
// Without properties, it's not really possible to verify the number of
3764-
// operands as we do not know the variadic operand segment sizes.
3765-
37663757
// Process the type inference graph in topological order, starting from
37673758
// types that are always fully-inferred: operands and results with
37683759
// constructible types. The type inference graph here will always be a

0 commit comments

Comments
 (0)