Skip to content

Commit dad73bc

Browse files
authored
AArch64: switch Apple CPUs (that support it) to v8.6a. (#73497)
We pretended they were v8.5a in the past because LLVM's modelling used to fold SM4 crypto support into v8.6a (which the CPUs don't actually have). That's changed in the last year so we can use the real value. This is mostly a tidy-up commit before one that'll bring in A17 and M3.
1 parent 95943d2 commit dad73bc

File tree

2 files changed

+12
-15
lines changed

2 files changed

+12
-15
lines changed

llvm/include/llvm/TargetParser/AArch64TargetParser.h

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -593,25 +593,22 @@ inline constexpr CpuInfo CpuInfos[] = {
593593
(AArch64::ExtensionBitset(
594594
{AArch64::AEK_AES, AArch64::AEK_SHA2, AArch64::AEK_SHA3,
595595
AArch64::AEK_FP16, AArch64::AEK_FP16FML}))},
596-
{"apple-a15", ARMV8_5A,
596+
{"apple-a15", ARMV8_6A,
597597
(AArch64::ExtensionBitset(
598598
{AArch64::AEK_AES, AArch64::AEK_SHA2, AArch64::AEK_SHA3,
599-
AArch64::AEK_FP16, AArch64::AEK_FP16FML,
600-
AArch64::AEK_BF16, AArch64::AEK_I8MM}))},
601-
{"apple-a16", ARMV8_5A,
599+
AArch64::AEK_FP16, AArch64::AEK_FP16FML}))},
600+
{"apple-a16", ARMV8_6A,
602601
(AArch64::ExtensionBitset(
603602
{AArch64::AEK_AES, AArch64::AEK_SHA2, AArch64::AEK_SHA3,
604-
AArch64::AEK_FP16, AArch64::AEK_FP16FML,
605-
AArch64::AEK_BF16, AArch64::AEK_I8MM}))},
603+
AArch64::AEK_FP16, AArch64::AEK_FP16FML}))},
606604
{"apple-m1", ARMV8_5A,
607605
(AArch64::ExtensionBitset(
608606
{AArch64::AEK_AES, AArch64::AEK_SHA2, AArch64::AEK_SHA3,
609607
AArch64::AEK_FP16, AArch64::AEK_FP16FML}))},
610-
{"apple-m2", ARMV8_5A,
608+
{"apple-m2", ARMV8_6A,
611609
(AArch64::ExtensionBitset(
612610
{AArch64::AEK_AES, AArch64::AEK_SHA2, AArch64::AEK_SHA3,
613-
AArch64::AEK_FP16, AArch64::AEK_FP16FML,
614-
AArch64::AEK_BF16, AArch64::AEK_I8MM}))},
611+
AArch64::AEK_FP16, AArch64::AEK_FP16FML}))},
615612
{"apple-s4", ARMV8_3A,
616613
(AArch64::ExtensionBitset(
617614
{AArch64::AEK_AES, AArch64::AEK_SHA2, AArch64::AEK_FP16}))},

llvm/unittests/TargetParser/TargetParserTest.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1389,25 +1389,25 @@ INSTANTIATE_TEST_SUITE_P(
13891389
AArch64::AEK_FP16FML, AArch64::AEK_SHA3})),
13901390
"8.5-A"),
13911391
ARMCPUTestParams<AArch64::ExtensionBitset>(
1392-
"apple-a15", "armv8.5-a", "crypto-neon-fp-armv8",
1392+
"apple-a15", "armv8.6-a", "crypto-neon-fp-armv8",
13931393
(AArch64::ExtensionBitset(
13941394
{AArch64::AEK_CRC, AArch64::AEK_AES, AArch64::AEK_SHA2,
13951395
AArch64::AEK_SHA3, AArch64::AEK_FP, AArch64::AEK_SIMD,
13961396
AArch64::AEK_LSE, AArch64::AEK_RAS, AArch64::AEK_RDM,
13971397
AArch64::AEK_RCPC, AArch64::AEK_DOTPROD, AArch64::AEK_FP16,
13981398
AArch64::AEK_FP16FML, AArch64::AEK_SHA3, AArch64::AEK_BF16,
13991399
AArch64::AEK_I8MM})),
1400-
"8.5-A"),
1400+
"8.6-A"),
14011401
ARMCPUTestParams<AArch64::ExtensionBitset>(
1402-
"apple-a16", "armv8.5-a", "crypto-neon-fp-armv8",
1402+
"apple-a16", "armv8.6-a", "crypto-neon-fp-armv8",
14031403
(AArch64::ExtensionBitset(
14041404
{AArch64::AEK_CRC, AArch64::AEK_AES, AArch64::AEK_SHA2,
14051405
AArch64::AEK_SHA3, AArch64::AEK_FP, AArch64::AEK_SIMD,
14061406
AArch64::AEK_LSE, AArch64::AEK_RAS, AArch64::AEK_RDM,
14071407
AArch64::AEK_RCPC, AArch64::AEK_DOTPROD, AArch64::AEK_FP16,
14081408
AArch64::AEK_FP16FML, AArch64::AEK_SHA3, AArch64::AEK_BF16,
14091409
AArch64::AEK_I8MM})),
1410-
"8.5-A"),
1410+
"8.6-A"),
14111411
ARMCPUTestParams<AArch64::ExtensionBitset>(
14121412
"apple-m1", "armv8.5-a", "crypto-neon-fp-armv8",
14131413
(AArch64::ExtensionBitset(
@@ -1418,15 +1418,15 @@ INSTANTIATE_TEST_SUITE_P(
14181418
AArch64::AEK_FP16FML, AArch64::AEK_SHA3})),
14191419
"8.5-A"),
14201420
ARMCPUTestParams<AArch64::ExtensionBitset>(
1421-
"apple-m2", "armv8.5-a", "crypto-neon-fp-armv8",
1421+
"apple-m2", "armv8.6-a", "crypto-neon-fp-armv8",
14221422
(AArch64::ExtensionBitset(
14231423
{AArch64::AEK_CRC, AArch64::AEK_AES, AArch64::AEK_SHA2,
14241424
AArch64::AEK_SHA3, AArch64::AEK_FP, AArch64::AEK_SIMD,
14251425
AArch64::AEK_LSE, AArch64::AEK_RAS, AArch64::AEK_RDM,
14261426
AArch64::AEK_RCPC, AArch64::AEK_DOTPROD, AArch64::AEK_FP16,
14271427
AArch64::AEK_FP16FML, AArch64::AEK_SHA3, AArch64::AEK_BF16,
14281428
AArch64::AEK_I8MM})),
1429-
"8.5-A"),
1429+
"8.6-A"),
14301430
ARMCPUTestParams<AArch64::ExtensionBitset>(
14311431
"apple-s4", "armv8.3-a", "crypto-neon-fp-armv8",
14321432
(AArch64::ExtensionBitset(

0 commit comments

Comments
 (0)