[lldb/crashlog] Fix test failure when creating a target using command options (#91653)

medismailben · web-flow · commit db9421381980 · 2024-05-09T14:13:44.000-07:00
This should fix the various crashlog test failures on the bots:

```
  lldb-shell :: ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test
  lldb-shell :: ScriptInterpreter/Python/Crashlog/interactive_crashlog_json.test
  lldb-shell :: ScriptInterpreter/Python/Crashlog/interactive_crashlog_legacy.test
  lldb-shell :: ScriptInterpreter/Python/Crashlog/last_exception_backtrace_crashlog.test
  lldb-shell :: ScriptInterpreter/Python/Crashlog/skipped_status_interactive_crashlog.test
```

When we create a target by using the command option, we don't set it in
the crashlog object which later on cause us to fail loading the images.

rdar://127832961

Signed-off-by: Med Ismail Bennani &lt;ismail@bennani.ma&gt;
diff --git a/lldb/examples/python/crashlog.py b/lldb/examples/python/crashlog.py
@@ -1494,6 +1494,7 @@ def load_crashlog_in_scripted_process(debugger, crashlog_path, options, result):
             raise InteractiveCrashLogException(
                 "couldn't create target provided by the user (%s)" % options.target_path
             )
+        crashlog.target = target
 
     # 2. If the user didn't provide a target, try to create a target using the symbolicator
     if not target or not target.IsValid():

Original file line number	Diff line number	Diff line change
`@@ -1494,6 +1494,7 @@ def load_crashlog_in_scripted_process(debugger, crashlog_path, options, result):`
`1494`	`1494`	`raise InteractiveCrashLogException(`
`1495`	`1495`	`"couldn't create target provided by the user (%s)" % options.target_path`
`1496`	`1496`	`)`
	`1497`	`+ crashlog.target = target`
`1497`	`1498`
`1498`	`1499`	`# 2. If the user didn't provide a target, try to create a target using the symbolicator`
`1499`	`1500`	`if not target or not target.IsValid():`