Skip to content

Commit dba2dd2

Browse files
authored
Revert "[CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5." (#83214)
Reverts #82840
1 parent bcbce80 commit dba2dd2

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

clang/lib/Driver/ToolChains/Clang.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4479,10 +4479,9 @@ renderDebugOptions(const ToolChain &TC, const Driver &D, const llvm::Triple &T,
44794479
options::OPT_gpubnames, options::OPT_gno_pubnames);
44804480
if (DwarfFission != DwarfFissionKind::None ||
44814481
(PubnamesArg && checkDebugInfoOption(PubnamesArg, Args, D, TC)))
4482-
if (DebuggerTuning != llvm::DebuggerKind::LLDB &&
4483-
(!PubnamesArg ||
4484-
(!PubnamesArg->getOption().matches(options::OPT_gno_gnu_pubnames) &&
4485-
!PubnamesArg->getOption().matches(options::OPT_gno_pubnames))))
4482+
if (!PubnamesArg ||
4483+
(!PubnamesArg->getOption().matches(options::OPT_gno_gnu_pubnames) &&
4484+
!PubnamesArg->getOption().matches(options::OPT_gno_pubnames)))
44864485
CmdArgs.push_back(PubnamesArg && PubnamesArg->getOption().matches(
44874486
options::OPT_gpubnames)
44884487
? "-gpubnames"

clang/test/Driver/split-debug.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,3 @@
124124
// G1_NOSPLIT: "-debug-info-kind=line-tables-only"
125125
// G1_NOSPLIT-NOT: "-split-dwarf-file"
126126
// G1_NOSPLIT-NOT: "-split-dwarf-output"
127-
128-
/// Do not generate -ggnu-pubnames for -glldb
129-
// RUN: %clang -### -c -target x86_64 -gsplit-dwarf -g -glldb %s 2>&1 | FileCheck %s --check-prefixes=GLLDBSPLIT
130-
131-
// GLLDBSPLIT-NOT: "-ggnu-pubnames"

0 commit comments

Comments
 (0)