Skip to content

Commit dc18532

Browse files
committed
[libc++][vector] include formatter only in C++23
This is to reduce included header file size in pre C++23 build. e.g. 2% of total included file coming from formatter_bool.h in chrome build. https://commondatastorage.googleapis.com/chromium-browser-clang/chrome_includes_2024-10-17_004801.html#view=edges&filter=&sort=asize&reverse=&includer=%5Ethird_party%2Flibc%5C%2B%5C%2B%2Fsrc%2Finclude%2Fvector%24&included=&limit=1000
1 parent d989c24 commit dc18532

File tree

6 files changed

+5
-7
lines changed

6 files changed

+5
-7
lines changed

libcxx/include/vector

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -324,8 +324,6 @@ template<class T, class charT> requires is-vector-bool-reference<T> // Since C++
324324
#include <__config>
325325
#include <__debug_utils/sanitizers.h>
326326
#include <__format/enable_insertable.h>
327-
#include <__format/formatter.h>
328-
#include <__format/formatter_bool.h>
329327
#include <__functional/hash.h>
330328
#include <__functional/unary_function.h>
331329
#include <__fwd/vector.h>
@@ -391,6 +389,11 @@ template<class T, class charT> requires is-vector-bool-reference<T> // Since C++
391389
#include <compare>
392390
#include <initializer_list>
393391

392+
#if _LIBCPP_STD_VER >= 23
393+
# include <__format/formatter.h>
394+
# include <__format/formatter_bool.h>
395+
#endif
396+
394397
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
395398
# pragma GCC system_header
396399
#endif

libcxx/test/libcxx/transitive_includes/cxx03.csv

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2596,7 +2596,6 @@ variant typeinfo
25962596
variant utility
25972597
variant version
25982598
vector algorithm
2599-
vector array
26002599
vector atomic
26012600
vector bit
26022601
vector cctype

libcxx/test/libcxx/transitive_includes/cxx11.csv

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2596,7 +2596,6 @@ variant typeinfo
25962596
variant utility
25972597
variant version
25982598
vector algorithm
2599-
vector array
26002599
vector atomic
26012600
vector bit
26022601
vector cctype

libcxx/test/libcxx/transitive_includes/cxx14.csv

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2649,7 +2649,6 @@ variant typeinfo
26492649
variant utility
26502650
variant version
26512651
vector algorithm
2652-
vector array
26532652
vector atomic
26542653
vector bit
26552654
vector cctype

libcxx/test/libcxx/transitive_includes/cxx17.csv

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2620,7 +2620,6 @@ variant typeinfo
26202620
variant utility
26212621
variant version
26222622
vector algorithm
2623-
vector array
26242623
vector atomic
26252624
vector bit
26262625
vector cctype

libcxx/test/libcxx/transitive_includes/cxx20.csv

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2616,7 +2616,6 @@ variant typeinfo
26162616
variant utility
26172617
variant version
26182618
vector algorithm
2619-
vector array
26202619
vector atomic
26212620
vector bit
26222621
vector cctype

0 commit comments

Comments
 (0)