Skip to content

Commit dcaf3ad

Browse files
committed
address tex
1 parent 3b2afe7 commit dcaf3ad

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

clang/lib/Sema/SemaDeclAttr.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7355,10 +7355,10 @@ static void DiagnoseHLSLResourceRegType(Sema &S, SourceLocation &ArgLoc,
73557355
PrintingPolicy PP = S.getPrintingPolicy();
73567356
std::string typestr = QualType::getAsString(QT.split(), PP);
73577357

7358-
if (Slot[0] != 'b' && Slot[0] != 'c' && Slot[0] != 'i')
7358+
if (Slot[0] != 't')
73597359
S.Diag(ArgLoc,
73607360
diag::err_hlsl_mismatching_register_builtin_type_and_name)
7361-
<< Slot.substr(0, 1) << typestr << "'b, c, or i";
7361+
<< Slot.substr(0, 1) << typestr << "'t'";
73627362
return;
73637363
}
73647364

clang/test/SemaHLSL/resource_binding_attr_error.hlsl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ void foo2() {
4444
// expected-warning@+1 {{'register' attribute only applies to cbuffer/tbuffer and external global variables}}
4545
extern RWBuffer<float> U2 : register(u5);
4646
}
47-
// expected-error@+1 {{invalid register name prefix 'u' for 'float' (expected 'b, c, or i)}}
47+
// expected-error@+1 {{invalid register name prefix 'u' for 'float' (expected 't')}}
4848
float b : register(u0, space1);
4949

5050
// expected-warning@+1 {{'register' attribute only applies to cbuffer/tbuffer and external global variables}}

clang/test/SemaHLSL/resource_binding_attr_error_mismatch.hlsl

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,22 +20,22 @@ RWBuffer<int> b : register(t2, space1);
2020
// NOT YET IMPLEMENTED : {{invalid register name prefix 't' for register type 'RWTexture3D' (expected 'u')}}
2121
// NOT YET IMPLEMENTED RWTexture3D<float4> RWT3D_u1 : register(t1)
2222

23-
// NOT YET IMPLEMENTED : {{invalid register name prefix 'b' for register type 'Texture2DMS' (expected 't' or 's')}}
24-
// NOT YET IMPLEMENTED TextureCube TCube_b2 : register(B2);
23+
// NOT YET IMPLEMENTED : {{invalid register name prefix 'b' for register type 'TextureCube' (expected 't')}}
24+
// NOT YET IMPLEMENTED TextureCube <float> t8 : register(b8);
2525

26-
// NOT YET IMPLEMENTED : {{invalid register name prefix 'b' for register type 'Texture2DMS' (expected 't')}}
26+
// NOT YET IMPLEMENTED : {{invalid register name prefix 'b' for register type 'TextureCubeArray' (expected 't')}}
2727
// NOT YET IMPLEMENTED TextureCubeArray TCubeArray_t2 : register(b2);
2828

29-
// NOT YET IMPLEMENTED : {{invalid register name prefix 'b' for register type 'Texture2DMS' (expected 't' or 's')}}
29+
// NOT YET IMPLEMENTED : {{invalid register name prefix 'b' for register type 'Texture1DArray' (expected 't')}}
3030
// NOT YET IMPLEMENTED Texture1DArray T1DArray_t2 : register(b2);
3131

32-
// NOT YET IMPLEMENTED : {{invalid register name prefix 'u' for register type 'Texture2DMS' (expected 't' or 's')}}
32+
// NOT YET IMPLEMENTED : {{invalid register name prefix 'u' for register type 'Texture2DArray' (expected 't')}}
3333
// NOT YET IMPLEMENTED Texture2DArray T2DArray_b2 : register(B2);
3434

35-
// NOT YET IMPLEMENTED : {{invalid register name prefix 'u' for register type 'Texture2DMS' (expected 'b' or 'c' or 'i')}}
35+
// NOT YET IMPLEMENTED : {{invalid register name prefix 'u' for register type 'Texture2DMSArray' (expected 't')}}
3636
// NOT YET IMPLEMENTED Texture2DMSArray<float4> msTextureArray : register(t2, space2);
3737

38-
// NOT YET IMPLEMENTED : {{invalid register name prefix 'u' for register type 'TCubeArray_f2' (expected 't' or 's')}}
38+
// NOT YET IMPLEMENTED : {{invalid register name prefix 'u' for register type 'TextureCubeArray' (expected 't')}}
3939
// NOT YET IMPLEMENTED TextureCubeArray TCubeArray_f2 : register(u2);
4040

4141
// NOT YET IMPLEMENTED : {{invalid register name prefix 'u' for register type 'TypedBuffer' (expected 't')}}
@@ -59,10 +59,10 @@ tbuffer f : register(s2, space1) {}
5959

6060
// NOT YET IMPLEMENTED : RTAccelerationStructure doesn't have any example tests in DXC
6161

62-
// NOT YET IMPLEMENTED : {{invalid register name prefix 'u' for register type 'FeedbackTexture2D' (expected 'b' or 'c' or 'i')}}
62+
// NOT YET IMPLEMENTED : {{invalid register name prefix 'u' for register type 'FeedbackTexture2D' (expected 't')}}
6363
// NOT YET IMPLEMENTED FeedbackTexture2D<float> FBTex2D[3][] : register(u0, space26);
6464

65-
// NOT YET IMPLEMENTED : {{invalid register name prefix 'u' for register type 'FeedbackTexture2DArray' (expected 'b' or 'c' or 'i')}}
65+
// NOT YET IMPLEMENTED : {{invalid register name prefix 'u' for register type 'FeedbackTexture2DArray' (expected 't')}}
6666
// NOT YET IMPLEMENTED FeedbackTexture2DArray<float> FBTex2DArr[3][2][] : register(u0, space27);
6767

6868

0 commit comments

Comments
 (0)