Skip to content

Commit dd2b04d

Browse files
committed
[CodeGen][ShrinkWrap] Clarify StackAddressUsedBlockInfo meaning
1 parent d4ef4b8 commit dd2b04d

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

llvm/lib/CodeGen/ShrinkWrap.cpp

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,9 +161,10 @@ class ShrinkWrap : public MachineFunctionPass {
161161
/// Current MachineFunction.
162162
MachineFunction *MachineFunc = nullptr;
163163

164-
/// Is `true` for block numbers where we can guarantee no stack access
165-
/// or computation of stack-relative addresses on any CFG path including
166-
/// the block itself.
164+
/// Is `true` for the block numbers where we assume possible stack accesses
165+
/// or computation of stack-relative addresses on any CFG path including the block itself.
166+
/// Is `false` for basic blocks where we can guarantee the opposite.
167+
/// False positives won't lead to incorrect analysis results, therefore this approach is fair.
167168
BitVector StackAddressUsedBlockInfo;
168169

169170
/// Check if \p MI uses or defines a callee-saved register or
@@ -948,6 +949,9 @@ bool ShrinkWrap::runOnMachineFunction(MachineFunction &MF) {
948949

949950
bool Changed = false;
950951

952+
// Initially, conservatively assume that stack addresses can be used in each
953+
// basic block and change the state only for those basic blocks for which we
954+
// were able to prove the opposite.
951955
StackAddressUsedBlockInfo.resize(MF.getNumBlockIDs(), true);
952956
bool HasCandidate = performShrinkWrapping(RPOT, RS.get());
953957
StackAddressUsedBlockInfo.clear();

0 commit comments

Comments
 (0)