Skip to content

Commit dd552fc

Browse files
committed
improve the warning message
1 parent 573eed8 commit dd552fc

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,8 @@ cl::opt<bool> Edit{
9292
};
9393
cl::opt<bool> Insert{
9494
"insert",
95-
cl::desc("Allow header insertions (deprecated. Use -disable-insert instead)"),
95+
cl::desc(
96+
"Allow header insertions (deprecated. Use -disable-insert instead)"),
9697
cl::init(true),
9798
cl::cat(IncludeCleaner),
9899
};
@@ -196,17 +197,19 @@ class Action : public clang::ASTFrontendAction {
196197
getCompilerInstance().getPreprocessor(), HeaderFilter);
197198

198199
if (!Insert) {
199-
llvm::errs() << "`-insert=0` is deprecated in favor of `-disable-insert`. "
200-
"The old flag was confusing since it suggested that inserts "
201-
"were disabled by default, when they were actually enabled. "
202-
"See https://github.com/llvm/llvm-project/issues/132983\n";
200+
llvm::errs()
201+
<< "[WARNING] -insert is deprecated in favor of `-disable-insert`. "
202+
"The old flag was confusing since it suggested that inserts "
203+
"were disabled by default, when they were actually enabled. "
204+
"See https://github.com/llvm/llvm-project/issues/132983\n";
203205
}
204206

205207
if (!Remove) {
206-
llvm::errs() << "`-remove=0` is deprecated in favor of `-disable-remove`. "
207-
"The old flag was confusing since it suggested that removes "
208-
"were disabled by default, when they were actually enabled. "
209-
"See https://github.com/llvm/llvm-project/issues/132983\n";
208+
llvm::errs()
209+
<< "[WARNING] -remove is deprecated in favor of `-disable-remove`. "
210+
"The old flag was confusing since it suggested that removes "
211+
"were disabled by default, when they were actually enabled. "
212+
"See https://github.com/llvm/llvm-project/issues/132983\n";
210213
}
211214

212215
if (!Insert || DisableInsert)

0 commit comments

Comments
 (0)