[Transforms] Avoid repeated hash lookups (NFC) (#109244)

kazutakahirata · web-flow · commit ddd5741521ed · 2024-09-19T09:15:57.000-07:00
diff --git a/llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h b/llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h
@@ -859,9 +859,9 @@ bool SampleProfileLoaderBaseImpl<BT>::propagateThroughEdges(
         LLVM_DEBUG(dbgs() << "Set self-referential edge weight to: ";
                    printEdgeWeight(dbgs(), SelfReferentialEdge));
       }
-      if (UpdateBlockCount && !VisitedBlocks.count(EC) && TotalWeight > 0) {
+      if (UpdateBlockCount && TotalWeight > 0 &&
+          VisitedBlocks.insert(EC).second) {
         BlockWeights[EC] = TotalWeight;
-        VisitedBlocks.insert(EC);
         Changed = true;
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -859,9 +859,9 @@ bool SampleProfileLoaderBaseImpl<BT>::propagateThroughEdges(`
`859`	`859`	`LLVM_DEBUG(dbgs() << "Set self-referential edge weight to: ";`
`860`	`860`	`printEdgeWeight(dbgs(), SelfReferentialEdge));`
`861`	`861`	`}`
`862`		`- if (UpdateBlockCount && !VisitedBlocks.count(EC) && TotalWeight > 0) {`
	`862`	`+ if (UpdateBlockCount && TotalWeight > 0 &&`
	`863`	`+ VisitedBlocks.insert(EC).second) {`
`863`	`864`	`BlockWeights[EC] = TotalWeight;`
`864`		`- VisitedBlocks.insert(EC);`
`865`	`865`	`Changed = true;`
`866`	`866`	`}`
`867`	`867`	`}`