Skip to content

Commit dde4fe6

Browse files
committed
expandFMINIMUM_FMAXIMUM: FMAXNUM/FMINNUM treat +0>-0
ISD::FMAXNUM and ISD::FMINNUM treat +0.0>-0.0 now, so let's set MinMaxMustRespectOrderedZero for it.
1 parent d9bab33 commit dde4fe6

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8573,15 +8573,14 @@ SDValue TargetLowering::expandFMINIMUM_FMAXIMUM(SDNode *N,
85738573
unsigned CompOpcIeee = IsMax ? ISD::FMAXNUM_IEEE : ISD::FMINNUM_IEEE;
85748574
unsigned CompOpc = IsMax ? ISD::FMAXNUM : ISD::FMINNUM;
85758575

8576-
// FIXME: We should probably define fminnum/fmaxnum variants with correct
8577-
// signed zero behavior.
85788576
bool MinMaxMustRespectOrderedZero = false;
85798577

85808578
if (isOperationLegalOrCustom(CompOpcIeee, VT)) {
85818579
MinMax = DAG.getNode(CompOpcIeee, DL, VT, LHS, RHS, Flags);
85828580
MinMaxMustRespectOrderedZero = true;
85838581
} else if (isOperationLegalOrCustom(CompOpc, VT)) {
85848582
MinMax = DAG.getNode(CompOpc, DL, VT, LHS, RHS, Flags);
8583+
MinMaxMustRespectOrderedZero = true;
85858584
} else {
85868585
if (VT.isVector() && !isOperationLegalOrCustom(ISD::VSELECT, VT))
85878586
return DAG.UnrollVectorOp(N);

0 commit comments

Comments
 (0)