Skip to content

Commit de4f2c9

Browse files
[lldb][test] Enable TestDAP_runInTerminal on non-x86 architectures (#111543)
I don't see an obvious reason it has to be x86 specific and local testing on Arm and AArch64 is fine. Originally disabled in 50337fb in response to failures apparently caused by https://reviews.llvm.org/D93951. Perhaps those still exist but worth trying this and checking I think.
1 parent a4de127 commit de4f2c9

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

lldb/test/API/tools/lldb-dap/runInTerminal/TestDAP_runInTerminal.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ def isTestSupported(self):
4444
return False
4545

4646
@skipIfWindows
47-
@skipIf(archs=no_match(["x86_64"]))
4847
def test_runInTerminal(self):
4948
if not self.isTestSupported():
5049
return
@@ -90,7 +89,6 @@ def test_runInTerminal(self):
9089
env = self.dap_server.request_evaluate("foo")["body"]["result"]
9190
self.assertIn("bar", env)
9291

93-
@skipIf(archs=no_match(["x86_64"]))
9492
def test_runInTerminalWithObjectEnv(self):
9593
if not self.isTestSupported():
9694
return
@@ -114,7 +112,6 @@ def test_runInTerminalWithObjectEnv(self):
114112
self.assertEqual("BAR", request_envs["FOO"])
115113

116114
@skipIfWindows
117-
@skipIf(archs=no_match(["x86_64"]))
118115
def test_runInTerminalInvalidTarget(self):
119116
if not self.isTestSupported():
120117
return
@@ -133,7 +130,6 @@ def test_runInTerminalInvalidTarget(self):
133130
)
134131

135132
@skipIfWindows
136-
@skipIf(archs=no_match(["x86_64"]))
137133
def test_missingArgInRunInTerminalLauncher(self):
138134
if not self.isTestSupported():
139135
return
@@ -148,7 +144,6 @@ def test_missingArgInRunInTerminalLauncher(self):
148144
)
149145

150146
@skipIfWindows
151-
@skipIf(archs=no_match(["x86_64"]))
152147
def test_FakeAttachedRunInTerminalLauncherWithInvalidProgram(self):
153148
if not self.isTestSupported():
154149
return
@@ -175,7 +170,6 @@ def test_FakeAttachedRunInTerminalLauncherWithInvalidProgram(self):
175170
self.assertIn("No such file or directory", stderr)
176171

177172
@skipIfWindows
178-
@skipIf(archs=no_match(["x86_64"]))
179173
def test_FakeAttachedRunInTerminalLauncherWithValidProgram(self):
180174
if not self.isTestSupported():
181175
return
@@ -202,7 +196,6 @@ def test_FakeAttachedRunInTerminalLauncherWithValidProgram(self):
202196
self.assertIn("foo", stdout)
203197

204198
@skipIfWindows
205-
@skipIf(archs=no_match(["x86_64"]))
206199
def test_FakeAttachedRunInTerminalLauncherAndCheckEnvironment(self):
207200
if not self.isTestSupported():
208201
return
@@ -223,7 +216,6 @@ def test_FakeAttachedRunInTerminalLauncherAndCheckEnvironment(self):
223216
self.assertIn("FOO=BAR", stdout)
224217

225218
@skipIfWindows
226-
@skipIf(archs=no_match(["x86_64"]))
227219
def test_NonAttachedRunInTerminalLauncher(self):
228220
if not self.isTestSupported():
229221
return

0 commit comments

Comments
 (0)