Skip to content

Commit de85739

Browse files
committed
[clang] NFCI: Use FileEntryRef in additional module maps
1 parent 0faee97 commit de85739

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

clang/lib/Serialization/ASTReader.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4096,11 +4096,11 @@ ASTReader::ReadModuleMapFileBlock(RecordData &Record, ModuleFile &F,
40964096
return OutOfDate;
40974097
}
40984098

4099-
llvm::SmallPtrSet<const FileEntry *, 1> AdditionalStoredMaps;
4099+
llvm::SmallPtrSet<FileEntryRef, 1> AdditionalStoredMaps;
41004100
for (unsigned I = 0, N = Record[Idx++]; I < N; ++I) {
41014101
// FIXME: we should use input files rather than storing names.
41024102
std::string Filename = ReadPath(F, Record, Idx);
4103-
auto SF = FileMgr.getFile(Filename, false, false);
4103+
auto SF = FileMgr.getOptionalFileRef(Filename, false, false);
41044104
if (!SF) {
41054105
if (!canRecoverFromOutOfDate(F.FileName, ClientLoadCapabilities))
41064106
Error("could not find file '" + Filename +"' referenced by AST file");
@@ -4126,10 +4126,10 @@ ASTReader::ReadModuleMapFileBlock(RecordData &Record, ModuleFile &F,
41264126

41274127
// Check any additional module map files that are in the pcm, but not
41284128
// found in header search. Cases that match are already removed.
4129-
for (const FileEntry *ModMap : AdditionalStoredMaps) {
4129+
for (FileEntryRef ModMap : AdditionalStoredMaps) {
41304130
if (!canRecoverFromOutOfDate(F.FileName, ClientLoadCapabilities))
41314131
Diag(diag::err_module_different_modmap)
4132-
<< F.ModuleName << /*not new*/1 << ModMap->getName();
4132+
<< F.ModuleName << /*not new*/1 << ModMap.getName();
41334133
return OutOfDate;
41344134
}
41354135
}

clang/lib/Serialization/ASTWriter.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1383,13 +1383,13 @@ void ASTWriter::WriteControlBlock(Preprocessor &PP, ASTContext &Context,
13831383
if (auto *AdditionalModMaps =
13841384
Map.getAdditionalModuleMapFiles(WritingModule)) {
13851385
Record.push_back(AdditionalModMaps->size());
1386-
SmallVector<const FileEntry *, 1> ModMaps(AdditionalModMaps->begin(),
1387-
AdditionalModMaps->end());
1388-
llvm::sort(ModMaps, [](const FileEntry *A, const FileEntry *B) {
1389-
return A->getName() < B->getName();
1386+
SmallVector<FileEntryRef, 1> ModMaps(AdditionalModMaps->begin(),
1387+
AdditionalModMaps->end());
1388+
llvm::sort(ModMaps, [](FileEntryRef A, FileEntryRef B) {
1389+
return A.getName() < B.getName();
13901390
});
1391-
for (const FileEntry *F : ModMaps)
1392-
AddPath(F->getName(), Record);
1391+
for (FileEntryRef F : ModMaps)
1392+
AddPath(F.getName(), Record);
13931393
} else {
13941394
Record.push_back(0);
13951395
}

0 commit comments

Comments
 (0)