address review comments

forbid pointers

Author: Thorsten Schütt

llvm/lib/CodeGen/MachineVerifier.cpp

@@ -1550,6 +1550,12 @@ void MachineVerifier::verifyPreISelGenericInstruction(const MachineInstr *MI) {
     LLT SrcTy = MRI->getType(MI->getOperand(1).getReg());
     LLT SrcTy2 = MRI->getType(MI->getOperand(2).getReg());
 
+    if (DstTy.isPointerOrPointerVector() || SrcTy.isPointerOrPointerVector() ||
+        SrcTy2.isPointerOrPointerVector()) {
+      report("Generic scmp/ucmp does not support pointers", MI);
+      break;
+    }
+
     if ((DstTy.isVector() != SrcTy.isVector()) ||
         (DstTy.isVector() &&
          DstTy.getElementCount() != SrcTy.getElementCount())) {

llvm/test/MachineVerifier/test_uscmp.mir

@@ -1,19 +1,26 @@
-# RUN: not --crash llc -verify-machineinstrs -mtriple=arm64 -run-pass none -o /dev/null %s 2>&1 | FileCheck %s
+# RUN: not --crash llc -verify-machineinstrs -run-pass none -mtriple=arm64 -o /dev/null %s 2>&1 | FileCheck %s
 # REQUIRES: aarch64-registered-target
 
 ---
 name:            test_uscmp
 body:             |
   bb.0:
 
+    %12:_(p0) = G_IMPLICIT_DEF
+    %13:_(p0) = G_IMPLICIT_DEF
+    ; CHECK: Generic scmp/ucmp does not support pointers
+    %14:_(p0) = G_SCMP %12, %13
+
     %3:_(<2 x s32>) = G_IMPLICIT_DEF
     %4:_(<2 x s32>) = G_IMPLICIT_DEF
     ; CHECK: Generic vector scmp/ucmp must preserve number of lanes
     %5:_(s1) = G_UCMP  %3, %4
 
-    %12:_(s32) = G_CONSTANT i32 0
-    %13:_(s64) = G_CONSTANT i64 2
+    %15:_(s32) = G_CONSTANT i32 0
+    %16:_(s64) = G_CONSTANT i64 2
     ; CHECK: Generic scmp/ucmp must have same input types
-    %14:_(s1) = G_SCMP %12, %13
+    %17:_(s1) = G_SCMP %15, %16
+
+
 
 ...