Skip to content

Commit dfaa144

Browse files
authored
[NFC] [HWASan] clarify FIXME comment (#87689)
1 parent c91a0a2 commit dfaa144

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

compiler-rt/lib/hwasan/hwasan_thread_list.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@ static uptr RingBufferSize() {
5555
uptr desired_bytes = flags()->stack_history_size * sizeof(uptr);
5656
// FIXME: increase the limit to 8 once this bug is fixed:
5757
// https://bugs.llvm.org/show_bug.cgi?id=39030
58+
// Note that we *cannot* do that on Android, as the runtime will indefinitely
59+
// have to support code that is compiled with ashr, which only works with
60+
// shifts up to 6.
5861
for (int shift = 0; shift < 7; ++shift) {
5962
uptr size = 4096 * (1ULL << shift);
6063
if (size >= desired_bytes)

0 commit comments

Comments
 (0)