Skip to content

Commit dfe9bb4

Browse files
committed
[ELF] Attempt to fix test on big endian architectures
Summary: This test fails because AMDGPU has a check for little-endianness before returning the architecture. This test attempts to force the type to be considered little-endian for the purpose of this test.
1 parent 4dd5d96 commit dfe9bb4

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

llvm/unittests/Object/ELFObjectFileTest.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -305,12 +305,11 @@ TEST(ELFObjectFileTest, CheckOSAndTriple) {
305305
for (auto [Machine, OS, Triple] : Formats) {
306306
const DataForTest D(ELF::ELFCLASS64, ELF::ELFDATA2LSB, Machine, OS,
307307
ELF::EF_AMDGPU_MACH_AMDGCN_LAST);
308-
Expected<std::unique_ptr<ObjectFile>> ELFObjOrErr =
309-
object::ObjectFile::createELFObjectFile(
310-
MemoryBufferRef(toStringRef(D.Data), "dummyELF"));
308+
Expected<ELF64LEObjectFile> ELFObjOrErr = ELF64LEObjectFile::create(
309+
MemoryBufferRef(toStringRef(D.Data), "dummyELF"));
311310
ASSERT_THAT_EXPECTED(ELFObjOrErr, Succeeded());
312311

313-
auto &ELFObj = **ELFObjOrErr;
312+
auto &ELFObj = *ELFObjOrErr;
314313
EXPECT_EQ(Triple, ELFObj.makeTriple().getTriple());
315314
}
316315
}

0 commit comments

Comments
 (0)