Skip to content

Commit e04bf91

Browse files
authored
[lld-macho][NFC] Remove redundant checks (#67450)
`ignoreAutoLinkOptions` checks run both in `parseLCLinkerOptions` and `resolveLCLinkerOptions`. Convert the latter check to an assert.
1 parent 8c26e47 commit e04bf91

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

lld/MachO/Driver.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -514,15 +514,13 @@ void macho::resolveLCLinkerOptions() {
514514
for (unsigned i = 0; i < LCLinkerOptions.size(); ++i) {
515515
StringRef arg = LCLinkerOptions[i];
516516
if (arg.consume_front("-l")) {
517-
if (config->ignoreAutoLinkOptions.contains(arg))
518-
continue;
517+
assert(!config->ignoreAutoLinkOptions.contains(arg));
519518
addLibrary(arg, /*isNeeded=*/false, /*isWeak=*/false,
520519
/*isReexport=*/false, /*isHidden=*/false,
521520
/*isExplicit=*/false, LoadType::LCLinkerOption);
522521
} else if (arg == "-framework") {
523522
StringRef name = LCLinkerOptions[++i];
524-
if (config->ignoreAutoLinkOptions.contains(name))
525-
continue;
523+
assert(!config->ignoreAutoLinkOptions.contains(name));
526524
addFramework(name, /*isNeeded=*/false, /*isWeak=*/false,
527525
/*isReexport=*/false, /*isExplicit=*/false,
528526
LoadType::LCLinkerOption);

0 commit comments

Comments
 (0)