Skip to content

Commit e0a3f5b

Browse files
author
Eric Liu
committed
Move #include manipulation code to new lib/Tooling/Inclusions.
Summary: clangToolingCore is linked into almost everything (incl. clang), but not few tools need #include manipulation at this point. So pull this into a separate library in Tooling. Reviewers: ilya-biryukov Subscribers: klimek, mgorny, cfe-commits, thakis Differential Revision: https://reviews.llvm.org/D47068 llvm-svn: 332720
1 parent 1237095 commit e0a3f5b

File tree

11 files changed

+26
-15
lines changed

11 files changed

+26
-15
lines changed

clang/include/clang/Format/Format.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
#define LLVM_CLANG_FORMAT_FORMAT_H
1717

1818
#include "clang/Basic/LangOptions.h"
19-
#include "clang/Tooling/Core/IncludeStyle.h"
2019
#include "clang/Tooling/Core/Replacement.h"
20+
#include "clang/Tooling/Inclusions/IncludeStyle.h"
2121
#include "llvm/ADT/ArrayRef.h"
2222
#include "llvm/Support/Regex.h"
2323
#include <system_error>

clang/include/clang/Tooling/Core/HeaderIncludes.h renamed to clang/include/clang/Tooling/Inclusions/HeaderIncludes.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77
//
88
//===----------------------------------------------------------------------===//
99

10-
#ifndef LLVM_CLANG_TOOLING_CORE_HEADERINCLUDES_H
11-
#define LLVM_CLANG_TOOLING_CORE_HEADERINCLUDES_H
10+
#ifndef LLVM_CLANG_TOOLING_INCLUSIONS_HEADERINCLUDES_H
11+
#define LLVM_CLANG_TOOLING_INCLUSIONS_HEADERINCLUDES_H
1212

1313
#include "clang/Basic/SourceManager.h"
1414
#include "clang/Tooling/Core/Replacement.h"
15-
#include "clang/Tooling/Core/IncludeStyle.h"
15+
#include "clang/Tooling/Inclusions/IncludeStyle.h"
1616
#include "llvm/Support/Path.h"
1717
#include "llvm/Support/Regex.h"
1818
#include <unordered_map>
@@ -134,4 +134,4 @@ class HeaderIncludes {
134134
} // namespace tooling
135135
} // namespace clang
136136

137-
#endif // LLVM_CLANG_TOOLING_CORE_HEADERINCLUDES_H
137+
#endif // LLVM_CLANG_TOOLING_INCLUSIONS_HEADERINCLUDES_H

clang/include/clang/Tooling/Core/IncludeStyle.h renamed to clang/include/clang/Tooling/Inclusions/IncludeStyle.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
//
88
//===----------------------------------------------------------------------===//
99

10-
#ifndef LLVM_CLANG_TOOLING_CORE_INCLUDESTYLE_H
11-
#define LLVM_CLANG_TOOLING_CORE_INCLUDESTYLE_H
10+
#ifndef LLVM_CLANG_TOOLING_INCLUSIONS_INCLUDESTYLE_H
11+
#define LLVM_CLANG_TOOLING_INCLUSIONS_INCLUDESTYLE_H
1212

1313
#include "llvm/Support/YAMLTraits.h"
1414
#include <string>
@@ -130,4 +130,4 @@ struct ScalarEnumerationTraits<
130130
} // namespace yaml
131131
} // namespace llvm
132132

133-
#endif // LLVM_CLANG_TOOLING_CORE_INCLUDESTYLE_H
133+
#endif // LLVM_CLANG_TOOLING_INCLUSIONS_INCLUDESTYLE_H

clang/lib/Format/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,5 @@ add_clang_library(clangFormat
2020
clangBasic
2121
clangLex
2222
clangToolingCore
23+
clangToolingInclusions
2324
)

clang/lib/Format/Format.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
#include "clang/Basic/SourceManager.h"
3232
#include "clang/Basic/VirtualFileSystem.h"
3333
#include "clang/Lex/Lexer.h"
34-
#include "clang/Tooling/Core/HeaderIncludes.h"
34+
#include "clang/Tooling/Inclusions/HeaderIncludes.h"
3535
#include "llvm/ADT/STLExtras.h"
3636
#include "llvm/ADT/StringRef.h"
3737
#include "llvm/Support/Allocator.h"

clang/lib/Tooling/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ set(LLVM_LINK_COMPONENTS
44
)
55

66
add_subdirectory(Core)
7+
add_subdirectory(Inclusions)
78
add_subdirectory(Refactoring)
89
add_subdirectory(ASTDiff)
910

clang/lib/Tooling/Core/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ set(LLVM_LINK_COMPONENTS support)
22

33
add_clang_library(clangToolingCore
44
Diagnostic.cpp
5-
HeaderIncludes.cpp
6-
IncludeStyle.cpp
75
Lookup.cpp
86
Replacement.cpp
97

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
set(LLVM_LINK_COMPONENTS support)
2+
3+
add_clang_library(clangToolingInclusions
4+
HeaderIncludes.cpp
5+
IncludeStyle.cpp
6+
7+
LINK_LIBS
8+
clangBasic
9+
clangLex
10+
clangRewrite
11+
clangToolingCore
12+
)

clang/lib/Tooling/Core/HeaderIncludes.cpp renamed to clang/lib/Tooling/Inclusions/HeaderIncludes.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
//
88
//===----------------------------------------------------------------------===//
99

10-
#include "clang/Tooling/Core/HeaderIncludes.h"
10+
#include "clang/Tooling/Inclusions/HeaderIncludes.h"
1111
#include "clang/Basic/SourceManager.h"
1212
#include "clang/Lex/Lexer.h"
1313

clang/lib/Tooling/Core/IncludeStyle.cpp renamed to clang/lib/Tooling/Inclusions/IncludeStyle.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
//
88
//===----------------------------------------------------------------------===//
99

10-
#include "clang/Tooling/Core/IncludeStyle.h"
11-
10+
#include "clang/Tooling/Inclusions/IncludeStyle.h"
1211

1312
using clang::tooling::IncludeStyle;
1413

clang/unittests/Tooling/HeaderIncludesTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
//
88
//===----------------------------------------------------------------------===//
99

10-
#include "clang/Tooling/Core/HeaderIncludes.h"
10+
#include "clang/Tooling/Inclusions/HeaderIncludes.h"
1111
#include "../Tooling/ReplacementTest.h"
1212
#include "../Tooling/RewriterTestContext.h"
1313
#include "clang/Format/Format.h"

0 commit comments

Comments
 (0)