Skip to content

Commit e0de7f4

Browse files
committed
[InstCombine] Remove compatibility check
1 parent d2b422f commit e0de7f4

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

llvm/include/llvm/Transforms/InstCombine/InstCombine.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,6 @@ struct InstCombineOptions {
4343
MaxIterations = Value;
4444
return *this;
4545
}
46-
47-
/// Only enable skipping when two versions of parameters are exactly the same.
48-
bool isCompatibleWith(const InstCombineOptions &LastOption) const {
49-
return VerifyFixpoint == LastOption.VerifyFixpoint &&
50-
MaxIterations == LastOption.MaxIterations;
51-
}
5246
};
5347

5448
class InstCombinePass : public PassInfoMixin<InstCombinePass> {

llvm/lib/Transforms/InstCombine/InstructionCombining.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5546,7 +5546,7 @@ PreservedAnalyses InstCombinePass::run(Function &F,
55465546
FunctionAnalysisManager &AM) {
55475547
auto &LRT = AM.getResult<LastRunTrackingAnalysis>(F);
55485548
// No changes since last InstCombine pass, exit early.
5549-
if (LRT.shouldSkip(&ID, Options))
5549+
if (LRT.shouldSkip(&ID))
55505550
return PreservedAnalyses::all();
55515551

55525552
auto &AC = AM.getResult<AssumptionAnalysis>(F);
@@ -5566,13 +5566,13 @@ PreservedAnalyses InstCombinePass::run(Function &F,
55665566
if (!combineInstructionsOverFunction(F, Worklist, AA, AC, TLI, TTI, DT, ORE,
55675567
BFI, BPI, PSI, Options)) {
55685568
// No changes, all analyses are preserved.
5569-
LRT.update(&ID, /*Changed=*/false, Options);
5569+
LRT.update(&ID, /*Changed=*/false);
55705570
return PreservedAnalyses::all();
55715571
}
55725572

55735573
// Mark all the analyses that instcombine updates as preserved.
55745574
PreservedAnalyses PA;
5575-
LRT.update(&ID, /*Changed=*/true, Options);
5575+
LRT.update(&ID, /*Changed=*/true);
55765576
PA.preserve<LastRunTrackingAnalysis>();
55775577
PA.preserveSet<CFGAnalyses>();
55785578
return PA;

0 commit comments

Comments
 (0)