Skip to content

Commit e14d7ed

Browse files
committed
example should be inserting the non-extended vectors
1 parent 401b4b4 commit e14d7ed

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOps.td

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -965,11 +965,11 @@ def FMopaWide2WayOp
965965

966966
```mlir
967967
%undef = llvm.mlir.undef : vector<[8]xf16>
968-
%a0_ins = vector.scalable.insert %a0_ext, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
969-
%a1_ins = vector.scalable.insert %a1_ext, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
968+
%a0_ins = vector.scalable.insert %a0, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
969+
%a1_ins = vector.scalable.insert %a1, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
970970
%a_packed = "arm_sve.intr.zip1"(%a0_ins, %a1_ins) : (vector<[8]xf16>, vector<[8]xf16>) -> vector<[8]xf16>
971-
%b0_ins = vector.scalable.insert %b0_ext, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
972-
%b1_ins = vector.scalable.insert %b1_ext, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
971+
%b0_ins = vector.scalable.insert %b0, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
972+
%b1_ins = vector.scalable.insert %b1, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
973973
%b_packed = "arm_sve.intr.zip1"(%b0_ins, %b1_ins) : (vector<[8]xf16>, vector<[8]xf16>) -> vector<[8]xf16>
974974
%0 = arm_sme.fmopa_wide_2way %a_packed, %b_packed : vector<[8]xf16>, vector<[8]xf16> into vector<[4]x[4]xf32>
975975
```
@@ -1220,18 +1220,18 @@ def SMopaWide4WayOp
12201220

12211221
```mlir
12221222
%undef = llvm.mlir.undef : vector<[8]xf16>
1223-
%a0_ins = vector.scalable.insert %a0_ext, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
1224-
%a1_ins = vector.scalable.insert %a1_ext, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
1225-
%a2_ins = vector.scalable.insert %a2_ext, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
1226-
%a3_ins = vector.scalable.insert %a3_ext, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
1223+
%a0_ins = vector.scalable.insert %a0, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
1224+
%a1_ins = vector.scalable.insert %a1, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
1225+
%a2_ins = vector.scalable.insert %a2, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
1226+
%a3_ins = vector.scalable.insert %a3, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
12271227
%lhs0 = "arm_sve.intr.zip1"(%a0_ins, %a2_ins) : (vector<[8]xf16>, vector<[8]xf16>) -> vector<[8]xf16>
12281228
%lhs1 = "arm_sve.intr.zip1"(%a1_ins, %a3_ins) : (vector<[8]xf16>, vector<[8]xf16>) -> vector<[8]xf16>
12291229
%lhs = "arm_sve.intr.zip1"(%lhs0, %lhs1) : (vector<[8]xf16>, vector<[8]xf16>) -> vector<[8]xf16>
12301230

1231-
%b0_ins = vector.scalable.insert %b0_ext, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
1232-
%b1_ins = vector.scalable.insert %b1_ext, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
1233-
%b2_ins = vector.scalable.insert %b2_ext, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
1234-
%b3_ins = vector.scalable.insert %b3_ext, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
1231+
%b0_ins = vector.scalable.insert %b0, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
1232+
%b1_ins = vector.scalable.insert %b1, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
1233+
%b2_ins = vector.scalable.insert %b2, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
1234+
%b3_ins = vector.scalable.insert %b3, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
12351235
%rhs0 = "arm_sve.intr.zip1"(%b0_ins, %b2_ins) : (vector<[8]xf16>, vector<[8]xf16>) -> vector<[8]xf16>
12361236
%rhs1 = "arm_sve.intr.zip1"(%b1_ins, %b3_ins) : (vector<[8]xf16>, vector<[8]xf16>) -> vector<[8]xf16>
12371237
%rhs = "arm_sve.intr.zip1"(%rhs0, %rhs1) : (vector<[8]xf16>, vector<[8]xf16>) -> vector<[8]xf16>

mlir/include/mlir/Dialect/ArmSME/Transforms/Passes.td

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,11 +144,11 @@ def OuterProductWidening
144144

145145
```mlir
146146
%undef = llvm.mlir.undef : vector<[8]xf16>
147-
%a0_ins = vector.scalable.insert %a0_ext, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
148-
%a1_ins = vector.scalable.insert %a1_ext, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
147+
%a0_ins = vector.scalable.insert %a0, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
148+
%a1_ins = vector.scalable.insert %a1, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
149149
%a_packed = "arm_sve.intr.zip1"(%a0_ins, %a1_ins) : (vector<[8]xf16>, vector<[8]xf16>) -> vector<[8]xf16>
150-
%b0_ins = vector.scalable.insert %b0_ext, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
151-
%b1_ins = vector.scalable.insert %b1_ext, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
150+
%b0_ins = vector.scalable.insert %b0, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
151+
%b1_ins = vector.scalable.insert %b1, %undef[0] : vector<[4]xf16> into vector<[8]xf16>
152152
%b_packed = "arm_sve.intr.zip1"(%b0_ins, %b1_ins) : (vector<[8]xf16>, vector<[8]xf16>) -> vector<[8]xf16>
153153
%0 = arm_sme.fmopa_wide_2way %a_packed, %b_packed : vector<[8]xf16>, vector<[8]xf16> into vector<[4]x[4]xf32>
154154
```

0 commit comments

Comments
 (0)