Skip to content

Commit e1b332e

Browse files
committed
[cmake] Note future cleanup in comment. NFC
CMake 3.6 introduced CMAKE_TRY_COMPILE_PLATFORM_VARIABLES, which solves precisely the problem that necessitated init_user_prop, so we can switch over whenever we bump our minimum CMake requirement. llvm-svn: 352790
1 parent fc7faec commit e1b332e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

llvm/cmake/platforms/WinMsvc.cmake

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,9 @@
9292
# won't see the value of any arguments the user passed via -D. Since these are
9393
# necessary to properly configure MSVC in both the top-level configuration as well as
9494
# all feature-test invocations, we set environment variables with the values so that
95-
# these environments get inherited by child invocations.
95+
# these environments get inherited by child invocations. We can switch to
96+
# CMAKE_TRY_COMPILE_PLATFORM_VARIABLES once our minimum supported CMake version
97+
# is 3.6 or greater.
9698
function(init_user_prop prop)
9799
if(${prop})
98100
set(ENV{_${prop}} "${${prop}}")

0 commit comments

Comments
 (0)