Skip to content

Commit e1dcda9

Browse files
[libc][NFC] remove completed TODOs
There were some "TODO" messages that were for things that I have already completed. This patch removes those. Reviewed By: michaelrj Differential Revision: https://reviews.llvm.org/D121232
1 parent bf0ded8 commit e1dcda9

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

libc/src/__support/str_to_float.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ namespace __llvm_libc {
2121
namespace internal {
2222

2323
template <class T> uint32_t inline leading_zeroes(T inputNumber) {
24-
// TODO(michaelrj): investigate the portability of using something like
25-
// __builtin_clz for specific types.
2624
constexpr uint32_t BITS_IN_T = sizeof(T) * 8;
2725
if (inputNumber == 0) {
2826
return BITS_IN_T;

libc/test/src/__support/str_to_float_test.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -259,18 +259,6 @@ TEST(LlvmLibcStrToFloatTest, SimpleDecimalConversionExtraTypes) {
259259
EXPECT_EQ(double_output_mantissa, uint64_t(0x1AC53A7E04BCDA));
260260
EXPECT_EQ(output_exp2, uint32_t(1089));
261261
EXPECT_EQ(errno, 0);
262-
263-
// TODO(michaelrj): Get long double support working.
264-
265-
// __uint128_t longDoubleOutputMantissa = 0;
266-
// outputExp2 = 0;
267-
268-
// errno = 0;
269-
// __llvm_libc::internal::simple_decimal_conversion<long double>(
270-
// "123456789012345678900", &longDoubleOutputMantissa, &outputExp2);
271-
// EXPECT_EQ(longDoubleOutputMantissa, __uint128_t(0x1AC53A7E04BCDA));
272-
// EXPECT_EQ(outputExp2, uint32_t(1089));
273-
// EXPECT_EQ(errno, 0);
274262
}
275263

276264
#if defined(LONG_DOUBLE_IS_DOUBLE)

0 commit comments

Comments
 (0)