Change and add test case for diagnostic when doing a C-style bitcast on vectors of x86_fp80

Author: DaMatrix

clang/include/clang/Basic/DiagnosticASTKinds.td

@@ -317,7 +317,7 @@ def note_constexpr_memcpy_unsupported : Note<
   "source is not a contiguous array of at least %4 elements of type %3|"
   "destination is not a contiguous array of at least %4 elements of type %3}2">;
 def note_constexpr_bit_cast_unsupported_type : Note<
-  "constexpr bit_cast involving type %0 is not yet supported">;
+  "constexpr bit cast involving type %0 is not yet supported">;
 def note_constexpr_bit_cast_unsupported_bitfield : Note<
   "constexpr bit_cast involving bit-field is not yet supported">;
 def note_constexpr_bit_cast_invalid_type : Note<

clang/test/SemaCXX/constexpr-builtin-bit-cast-fp80.cpp

@@ -20,29 +20,47 @@ struct fp80x2_s {
   }
 };
 
-constexpr static fp80x2_v test_vec_fp80 = { 1, 2 };
-constexpr static fp80x2_s test_str_fp80 = { { 0, 0, 0, 0, 0, 0, 0, -128, -1, 63, 0, 0, 0, 0, 0, 0, 0, -128, 0, 64 }, {} };
+namespace builtin_bit_cast {
+  constexpr static fp80x2_v test_vec_fp80 = { 1, 2 };
+  constexpr static fp80x2_s test_str_fp80 = { { 0, 0, 0, 0, 0, 0, 0, -128, -1, 63, 0, 0, 0, 0, 0, 0, 0, -128, 0, 64 }, {} };
 
-// expected-error@+2 {{static assertion expression is not an integral constant expression}}
-// expected-note@+1 {{constexpr bit_cast involving type 'long double' is not yet supported}}
-static_assert(__builtin_bit_cast(fp80x2_s, test_vec_fp80) == test_str_fp80, "");
+  // expected-error@+2 {{static assertion expression is not an integral constant expression}}
+  // expected-note@+1 {{constexpr bit cast involving type 'long double' is not yet supported}}
+  static_assert(__builtin_bit_cast(fp80x2_s, test_vec_fp80) == test_str_fp80, "");
 
-// expected-error@+2 {{static assertion expression is not an integral constant expression}}
-// expected-note@+1 {{constexpr bit_cast involving type 'long double' is not yet supported}}
-static_assert(__builtin_bit_cast(fp80x2_s, __builtin_bit_cast(fp80x2_v, test_str_fp80)) == test_str_fp80, "");
+  // expected-error@+2 {{static assertion expression is not an integral constant expression}}
+  // expected-note@+1 {{constexpr bit cast involving type 'long double' is not yet supported}}
+  static_assert(__builtin_bit_cast(fp80x2_s, __builtin_bit_cast(fp80x2_v, test_str_fp80)) == test_str_fp80, "");
 
-// expected-error@+2 {{constexpr variable 'bad_str_fp80_0' must be initialized by a constant expression}}
-// expected-note@+1 {{constexpr bit_cast involving type 'long double' is not yet supported}}
-constexpr static char bad_str_fp80_0 = __builtin_bit_cast(fp80x2_s, test_vec_fp80)._pad[0];
+  // expected-error@+2 {{constexpr variable 'bad_str_fp80_0' must be initialized by a constant expression}}
+  // expected-note@+1 {{constexpr bit cast involving type 'long double' is not yet supported}}
+  constexpr static char bad_str_fp80_0 = __builtin_bit_cast(fp80x2_s, test_vec_fp80)._pad[0];
 
-// expected-error@+2 {{constexpr variable 'bad_str_fp80_1' must be initialized by a constant expression}}
-// expected-note@+1 {{constexpr bit_cast involving type 'long double' is not yet supported}}
-constexpr static char bad_str_fp80_1 = __builtin_bit_cast(fp80x2_s, test_vec_fp80)._pad[1];
+  // expected-error@+2 {{constexpr variable 'bad_str_fp80_1' must be initialized by a constant expression}}
+  // expected-note@+1 {{constexpr bit cast involving type 'long double' is not yet supported}}
+  constexpr static char bad_str_fp80_1 = __builtin_bit_cast(fp80x2_s, test_vec_fp80)._pad[1];
 
-// expected-error@+2 {{constexpr variable 'bad_str_fp80_11' must be initialized by a constant expression}}
-// expected-note@+1 {{constexpr bit_cast involving type 'long double' is not yet supported}}
-constexpr static char bad_str_fp80_11 = __builtin_bit_cast(fp80x2_s, test_vec_fp80)._pad[11];
+  // expected-error@+2 {{constexpr variable 'bad_str_fp80_11' must be initialized by a constant expression}}
+  // expected-note@+1 {{constexpr bit cast involving type 'long double' is not yet supported}}
+  constexpr static char bad_str_fp80_11 = __builtin_bit_cast(fp80x2_s, test_vec_fp80)._pad[11];
 
-// expected-error@+2 {{constexpr variable 'struct2v' must be initialized by a constant expression}}
-// expected-note@+1 {{constexpr bit_cast involving type 'long double' is not yet supported}}
-constexpr static fp80x2_v struct2v = __builtin_bit_cast(fp80x2_v, test_str_fp80);
+  // expected-error@+2 {{constexpr variable 'struct2v' must be initialized by a constant expression}}
+  // expected-note@+1 {{constexpr bit cast involving type 'long double' is not yet supported}}
+  constexpr static fp80x2_v struct2v = __builtin_bit_cast(fp80x2_v, test_str_fp80);
+}
+
+namespace c_cast {
+  typedef short v12i16 __attribute((vector_size(24)));
+  typedef long double v2f80 __attribute((vector_size(24)));
+
+  // FIXME: re-enable the corresponding test cases in CodeGen/const-init.c when
+  //  constexpr bitcast with x86_fp80 is supported
+
+  // expected-error@+2 {{constexpr variable 'b' must be initialized by a constant expression}}
+  // expected-note@+1 {{constexpr bit cast involving type 'long double' is not yet supported}}
+  constexpr static v12i16 b = (v12i16)(v2f80){1,2};
+
+  // expected-error@+2 {{constexpr variable 'c' must be initialized by a constant expression}}
+  // expected-note@+1 {{constexpr bit cast involving type 'long double' is not yet supported}}
+  constexpr static v2f80 c = (v2f80)(v12i16){0,0,0,-32768,16383,0,0,0,0,-32768,16384,0};
+}