Skip to content

Commit e33302f

Browse files
committed
Revert "[lldb][test] TestLocationListLookup.py: skip expr check on unsupported platforms (#74818)"
This reverts commit 11a7e57. Test fails: https://lab.llvm.org/buildbot/#/builders/219/builds/7416 and others.
1 parent ea85345 commit e33302f

File tree

1 file changed

+7
-20
lines changed

1 file changed

+7
-20
lines changed

lldb/test/API/functionalities/location-list-lookup/TestLocationListLookup.py

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@
77

88

99
class LocationListLookupTestCase(TestBase):
10-
def launch(self) -> lldb.SBProcess:
10+
@skipIf(oslist=["linux"], archs=["arm"])
11+
def test_loclist(self):
12+
self.build()
13+
1114
exe = self.getBuildArtifact("a.out")
1215
target = self.dbg.CreateTarget(exe)
1316
self.assertTrue(target, VALID_TARGET)
@@ -19,31 +22,15 @@ def launch(self) -> lldb.SBProcess:
1922
self.assertTrue(process.IsValid())
2023
self.assertTrue(process.is_stopped)
2124

22-
return process
23-
24-
def check_local_vars(self, process: lldb.SBProcess, check_expr: bool):
2525
# Find `bar` on the stack, then
2626
# make sure we can read out the local
2727
# variables (with both `frame var` and `expr`)
2828
for f in process.GetSelectedThread().frames:
29-
frame_name = f.GetDisplayFunctionName()
30-
if frame_name is not None and frame_name.startswith("Foo::bar"):
29+
if f.GetDisplayFunctionName().startswith("Foo::bar"):
3130
argv = f.GetValueForVariablePath("argv").GetChildAtIndex(0)
3231
strm = lldb.SBStream()
3332
argv.GetDescription(strm)
3433
self.assertNotEqual(strm.GetData().find("a.out"), -1)
3534

36-
if check_expr:
37-
process.GetSelectedThread().SetSelectedFrame(f.idx)
38-
self.expect_expr("this", result_type="Foo *")
39-
40-
@skipIf(oslist=["linux"], archs=["arm"])
41-
@skipIfDarwin
42-
def test_loclist_frame_var(self):
43-
self.build()
44-
self.check_local_vars(self.launch(), check_expr=False)
45-
46-
@skipUnlessDarwin
47-
def test_loclist_expr(self):
48-
self.build()
49-
self.check_local_vars(self.launch(), check_expr=True)
35+
process.GetSelectedThread().SetSelectedFrame(f.idx)
36+
self.expect_expr("this", result_type="Foo *")

0 commit comments

Comments
 (0)