Skip to content

Commit e3f16de

Browse files
authored
[unittest][Support] Fix bad negation of signed integer in LEB128Test.SLEB128Size (#72700)
I came across an undefined behavior when running Support unit tests with UBSAN on Windows. ```bash [ RUN ] LEB128Test.SLEB128Size C:\llvm\unittests\Support\LEB128Test.cpp:382:3: runtime error: negation of -9223372036854775808 cannot be represented in type 'long long'; cast to an unsigned type to negate this value to itself SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior C:\llvm\unittests\Support\LEB128Test.cpp:382:3 in ``` UBSAN did not report the same error on macOS, but the negation still seemed invalid (`0x8000000000000000LL == -0x8000000000000000LL` evaluated to `true`). I can confirm that `-0x7fffffffffffffffLL - 1` results in the expected value on both platforms.
1 parent c2ba2b2 commit e3f16de

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

llvm/unittests/Support/LEB128Test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ TEST(LEB128Test, SLEB128Size) {
379379
EXPECT_EQ(10u, getSLEB128Size(-0x4100000000000000LL));
380380

381381
EXPECT_EQ(10u, getSLEB128Size(-0x7fffffffffffffffLL));
382-
EXPECT_EQ(10u, getSLEB128Size(-0x8000000000000000LL));
382+
EXPECT_EQ(10u, getSLEB128Size(-0x7fffffffffffffffLL - 1));
383383
EXPECT_EQ(10u, getSLEB128Size(INT64_MIN));
384384
}
385385

0 commit comments

Comments
 (0)