Skip to content

Commit e4c3d25

Browse files
authored
[NFC][c-index-test] factor data len out (#129971)
Follow up of #129922
1 parent c14d3df commit e4c3d25

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

clang/tools/c-index-test/c-index-test.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3546,21 +3546,19 @@ static CXIdxClientContainer makeClientContainer(CXClientData *client_data,
35463546
char *newStr;
35473547
CXIdxClientFile file;
35483548
unsigned line, column;
3549-
size_t len;
3549+
size_t datalen;
35503550

35513551
name = info->name;
35523552
if (!name)
35533553
name = "<anon-tag>";
35543554

35553555
clang_indexLoc_getFileLocation(loc, &file, 0, &line, &column, 0);
35563556

3557-
len = sizeof(IndexDataStringList) + strlen(name) + digitCount(line) +
3558-
digitCount(column) + 3;
3559-
node = (IndexDataStringList *)malloc(len);
3557+
datalen = strlen(name) + digitCount(line) + digitCount(column) + 3;
3558+
node = (IndexDataStringList *)malloc(datalen + sizeof(IndexDataStringList));
35603559
assert(node);
35613560
newStr = node->data;
3562-
snprintf(newStr, len - sizeof(IndexDataStringList), "%s:%d:%d", name, line,
3563-
column);
3561+
snprintf(newStr, datalen, "%s:%d:%d", name, line, column);
35643562

35653563
/* Remember string so it can be freed later. */
35663564
index_data = (IndexData *)client_data;

0 commit comments

Comments
 (0)