Skip to content

Commit e52d3bd

Browse files
address comments
1 parent 447998d commit e52d3bd

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

llvm/lib/Target/X86/X86ISelLowering.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32817,8 +32817,7 @@ void X86TargetLowering::ReplaceNodeResults(SDNode *N,
3281732817
"Do not know how to legalize this Node");
3281832818
bool IsStrict = N->isStrictFPOpcode();
3281932819
SDValue Src = N->getOperand(IsStrict ? 1 : 0);
32820-
if (!Subtarget.hasFP16() || !Subtarget.hasVLX() ||
32821-
Src.getValueType().getVectorElementType() != MVT::f16)
32820+
if (Src.getValueType().getVectorElementType() != MVT::f16)
3282232821
return;
3282332822
SDValue Ext = IsStrict ? DAG.getConstantFP(0.0, dl, MVT::v2f16)
3282432823
: DAG.getUNDEF(MVT::v2f16);

llvm/test/CodeGen/X86/concat-fpext-v2bf16.ll

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
22
; RUN: llc < %s -mtriple=x86_64-- -mattr=avx512bf16,avx512fp16 | FileCheck %s
3-
define dso_local void @calc_matrix_tdpbf16ps(<2 x ptr> %ptr) local_unnamed_addr #0 {
4-
; CHECK-LABEL: calc_matrix_tdpbf16ps:
3+
4+
define void @test(<2 x ptr> %ptr) {
5+
; CHECK-LABEL: test:
56
; CHECK: # %bb.0: # %entry
67
; CHECK-NEXT: xorl %eax, %eax
78
; CHECK-NEXT: testb %al, %al
@@ -36,6 +37,4 @@ loop.127.preheader: ; preds = %then.13
3637
ret void
3738
}
3839

39-
; Function Attrs: nocallback nofree nosync nounwind willreturn memory(read)
40-
declare <2 x bfloat> @llvm.masked.gather.v2bf16.v2p0(<2 x ptr>, i32 immarg, <2 x i1>, <2 x bfloat>) #1
41-
40+
declare <2 x bfloat> @llvm.masked.gather.v2bf16.v2p0(<2 x ptr>, i32 immarg, <2 x i1>, <2 x bfloat>)

0 commit comments

Comments
 (0)